diff options
author | Michael Niewöhner <foss@mniewoehner.de> | 2020-08-25 19:38:14 +0200 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2020-09-08 05:44:28 +0000 |
commit | e10efa3a037c78c831a2b94c75eb0ab862412acf (patch) | |
tree | 8af3859afa32d019652f613c5a926d0ba64e62b8 /util/cbfstool | |
parent | 9da0279e1a99babe81a064441b97f6a93dd518bf (diff) | |
download | coreboot-e10efa3a037c78c831a2b94c75eb0ab862412acf.tar.xz |
util/apcb_edit: fix handling of binary SPD files
Passing binary SPD files to apcb_edit can lead to an encoding error,
since the files were read in text mode. To fix this, read SPD files
always in binary mode and only decode them, when `--hex` is set.
Tested by comparing output files from the same SPDs in both, binary and
hex mode.
Change-Id: I6b75a9e1234e71667bdc8cb4eb10daf8c0ac3c17
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44778
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'util/cbfstool')
0 files changed, 0 insertions, 0 deletions