diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2008-05-22 22:47:04 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2008-05-22 22:47:04 +0000 |
| commit | 6eb5012a8c74756bcb4534e22775ecf073461b88 (patch) | |
| tree | d597a9b7f9bd13f221f4e526bbcd98992d476165 /util/flashrom/flashrom.c | |
| parent | 1a02c8eeedd8085ec4df032a9c6a0ebfcb2805b7 (diff) | |
| download | coreboot-6eb5012a8c74756bcb4534e22775ecf073461b88.tar.xz | |
A bunch of cosmetic improvements (trivial).
- Fix typos and inconsistencies.
- Drop duplicate line which tells us the chip name twice.
- Also print the chip vendor, not only the name.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3348 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'util/flashrom/flashrom.c')
| -rw-r--r-- | util/flashrom/flashrom.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/util/flashrom/flashrom.c b/util/flashrom/flashrom.c index e366f94e93..e97f19610a 100644 --- a/util/flashrom/flashrom.c +++ b/util/flashrom/flashrom.c @@ -151,8 +151,9 @@ struct flashchip *probe_flash(struct flashchip *flash) flash->virtual_memory = bios; if (flash->probe(flash) == 1) { - printf("%s found at physical address 0x%lx.\n", - flash->name, flash_baseaddr); + printf("Found chip \"%s %s\" (%d KB) at physical address 0x%lx.\n", + flash->vendor, flash->name, flash->total_size, + flash_baseaddr); return flash; } munmap((void *)bios, size); @@ -360,7 +361,7 @@ int main(int argc, char *argv[]) } if (read_it && write_it) { - printf("-r and -w are mutually exclusive\n"); + printf("Error: -r and -w are mutually exclusive.\n"); usage(argv[0]); } @@ -432,7 +433,6 @@ int main(int argc, char *argv[]) flash = flashes[0]; - printf("Flash part is %s (%d KB).\n", flash->name, flash->total_size); if (TEST_OK_MASK != (flash->tested & TEST_OK_MASK)) { printf("===\n"); if (flash->tested & TEST_BAD_MASK) { @@ -480,7 +480,7 @@ int main(int argc, char *argv[]) buf = (uint8_t *) calloc(size, sizeof(char)); if (erase_it) { - printf("Erasing flash chip\n"); + printf("Erasing flash chip.\n"); if (!flash->erase) { fprintf(stderr, "Error: flashrom has no erase function for this flash chip.\n"); return 1; @@ -517,7 +517,7 @@ int main(int argc, char *argv[]) exit(1); } if (image_stat.st_size != flash->total_size * 1024) { - fprintf(stderr, "Error: Image size doesnt match\n"); + fprintf(stderr, "Error: Image size doesn't match\n"); exit(1); } |