diff options
| author | Peter Stuge <peter@stuge.se> | 2008-07-07 06:38:51 +0000 |
|---|---|---|
| committer | Peter Stuge <peter@stuge.se> | 2008-07-07 06:38:51 +0000 |
| commit | a4793182e892c71660e24dbe12198a653f7ec1e6 (patch) | |
| tree | c3e5bb7b62a251f94b1da1b0c9fd623c8286a013 /util/flashrom/it87spi.c | |
| parent | 5dc95de5e64638d5b95d7fd1fb7ef87887bfdbdc (diff) | |
| download | coreboot-a4793182e892c71660e24dbe12198a653f7ec1e6.tar.xz | |
flashrom: Trivial SPI cleanups
While writing a new SPI driver I fixed some things in the SPI code:
All calls to spi_command() had unneccessary #define duplications, and in some
cases the read count define could theoretically become harmful because NULL was
passed for the read buffer. Avoid a crash, should someone change the #defines.
I also noticed that the only caller of spi_page_program() was the it87 driver,
and spi_page_program() could only call back into the it87 driver. Removed the
function for easier-to-follow code and made it8716f_spi_page_program() static.
The ichspi driver's static page functions are already static.
Signed-off-by: Peter Stuge <peter@stuge.se>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3418 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'util/flashrom/it87spi.c')
| -rw-r--r-- | util/flashrom/it87spi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/flashrom/it87spi.c b/util/flashrom/it87spi.c index e6cd9d6af6..d1dd1d643f 100644 --- a/util/flashrom/it87spi.c +++ b/util/flashrom/it87spi.c @@ -192,7 +192,7 @@ int it8716f_spi_command(unsigned int writecnt, unsigned int readcnt, const unsig } /* Page size is usually 256 bytes */ -void it8716f_spi_page_program(int block, uint8_t *buf, uint8_t *bios) { +static void it8716f_spi_page_program(int block, uint8_t *buf, uint8_t *bios) { int i; spi_write_enable(); @@ -261,7 +261,7 @@ int it8716f_spi_chip_write(struct flashchip *flash, uint8_t *buf) { it8716f_over512k_spi_chip_write(flash, buf); } else { for (i = 0; i < total_size / 256; i++) { - spi_page_program(i, buf, (uint8_t *)flash->virtual_memory); + it8716f_spi_page_program(i, buf, (uint8_t *)flash->virtual_memory); } } return 0; |