Jeremy Jackson wrote:

I'm guessing nobody has tried compiling it with 64bit userspace?

Patch makes it compile cleanly and stops a "SEGV instead of working"
issue.

I also added a few checks for errors on system calls.

Signed-off-by: Jeremy Jackson <jerj@coplanar.net>

Reworked and
Acked-by: Stefan Reinauer <stepan@coresystems.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2602 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

1 files changed, 14 insertions, 22 deletions

diff --git a/util/getpir/Makefile b/util/getpir/Makefile
index 07a6625c75..13bf47efc9 100644
--- a/util/getpir/Makefile
+++ b/util/getpir/Makefile
@@ -1,33 +1,25 @@
-# change to the path of your linuxbios tree
-#LINUXBIOSROOT=/home/rminnich/src//freebios/
-LINUXBIOSROOT=../..
+#
+#
+#
 
-INCLUDEPATH=$(LINUXBIOSROOT)/src/arch/i386/include
-INCLUDE2=$(LINUXBIOSROOT)/src/include
-
-getpir: getpir.c checksum.o code_gen.o
-	gcc -o getpir -I$(INCLUDEPATH) -I$(INCLUDE2) getpir.c checksum.o code_gen.o
-
-code_gen.o: code_gen.c
-	gcc -c -I$(INCLUDEPATH) -I$(INCLUDE2) code_gen.c
+CC=gcc
+CFLAGS=-O2 -D_GNU_SOURCE -DGETPIR -Wall
 
 all: getpir checkpir
+	./checkpir
 
-checkpir: checkpir.c checksum.o irq_tables.o
-	gcc -o checkpir -I$(INCLUDEPATH) -I$(INCLUDE2) irq_tables.o checksum.o checkpir.c
+getpir: getpir.o checksum.o code_gen.o
+	$(CC) $(CFLAGS) -o getpir $^
 
-checksum.o: checksum.c
-	gcc -c -I$(INCLUDEPATH) -I$(INCLUDE2) checksum.c 
+checkpir: checkpir.c checksum.o irq_tables.o
+	$(CC) $(CFLAGS) -o checkpir $^
 
-irq_tables.o: irq_tables.c  
-	gcc -c -I$(INCLUDEPATH) -I$(INCLUDE2) irq_tables.c
+irq_tables.c: getpir
+	./getpir
 
 clean:
 	rm -f getpir checkpir *.o *~
 
-cleantable:
-	rm -f irq_table.o
+distclean: clean
+	rm -f irq_tables.o irq_tables.c
 
-test:   checkpir
-	./checkpir ;\
-	exit 0;