diff options
| author | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-04-06 01:27:55 +0200 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-04-06 23:14:09 +0200 |
| commit | 1824ce3c402b0f09e852c464cd8d83f019ba85ec (patch) | |
| tree | 71a151d4e9769b3a7172a52fe495de8d4c1cc684 /util/kconfig/menu.c | |
| parent | 6654ab02fc4566ba768cf7b861efb8b4b6ab3b8a (diff) | |
| download | coreboot-1824ce3c402b0f09e852c464cd8d83f019ba85ec.tar.xz | |
kconfig: Fix warning "‘jump’ may be used uninitialized"
Warning:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
jump->offset = strlen(r->s);
Simplifies the test logic because (head && local) means (jump != 0)
and makes GCC happy when checking if the jump pointer was initialized.
Signed-off-by: Peter Kümmel <syntheticpp@gmx.net>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Change-Id: I43de391c9573a28c66d17e7dc535033be39060de
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/9312
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
Diffstat (limited to 'util/kconfig/menu.c')
| -rw-r--r-- | util/kconfig/menu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/kconfig/menu.c b/util/kconfig/menu.c index a26cc5d2a9..72c9dba84c 100644 --- a/util/kconfig/menu.c +++ b/util/kconfig/menu.c @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, { int i, j; struct menu *submenu[8], *menu, *location = NULL; - struct jump_key *jump; + struct jump_key *jump = NULL; str_printf(r, _("Prompt: %s\n"), _(prop->text)); menu = prop->menu->parent; @@ -586,7 +586,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, str_printf(r, _(" Location:\n")); for (j = 4; --i >= 0; j += 2) { menu = submenu[i]; - if (head && location && menu == location) + if (jump && menu == location) jump->offset = strlen(r->s); str_printf(r, "%*c-> %s", j, ' ', _(menu_get_prompt(menu))); |