diff options
| author | Alex Thiessen <alex.thiessen.de+coreboot@gmail.com> | 2018-01-16 23:05:48 +0000 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2018-01-23 05:42:51 +0000 |
| commit | 73f19dca386d775a880bdc945efaa6b9c77d9e94 (patch) | |
| tree | b7814be8453de7044ad8078fc048aae2514ec5d4 /util/lint/lint-extended-020-signed-off-by | |
| parent | 583e0522f14fde040f48d2444099e4dededfa185 (diff) | |
| download | coreboot-73f19dca386d775a880bdc945efaa6b9c77d9e94.tar.xz | |
util/lint: Unify checks for git worktree
Linters try to determine whether they are running in a git worktree so
that `git grep` can be used instead of `grep`. These checks are done in
different not truly correct ways and thus the linters don't use `git
grep` when running from a worktree subdirectory, e.g. in a git subtree
environment.
Unify checks using `git rev-parse --is-inside-work-tree`.
Change-Id: I3f54afc99ad0f0e3052cffdd32bdd9649cf3d720
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com>
Reviewed-on: https://review.coreboot.org/23297
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'util/lint/lint-extended-020-signed-off-by')
| -rwxr-xr-x | util/lint/lint-extended-020-signed-off-by | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/util/lint/lint-extended-020-signed-off-by b/util/lint/lint-extended-020-signed-off-by index 40b6e9eb42..065b286d34 100755 --- a/util/lint/lint-extended-020-signed-off-by +++ b/util/lint/lint-extended-020-signed-off-by @@ -16,7 +16,9 @@ # DESCR: Check for a signed-off-by line on the latest git commit # This test is mainly for the jenkins server -if [ -n "$(command -v git)" ] && [ -d .git ]; then +if [ -n "$(command -v git)" ] && \ + [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ] +then if [ -z "$(git log -n 1 | grep '[[:space:]]\+Signed-off-by: ')" ]; then echo "No Signed-off-by line in commit message" fi |