diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2011-11-14 12:40:34 -0800 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2012-03-30 20:26:50 +0200 |
| commit | a7b296d450c5d948b95c1342f726334b4e5a4c68 (patch) | |
| tree | 2e4939509d1ba3f74fd460a152cfa84c2b4b96f5 /util/nvramtool | |
| parent | 8acbc2a8865ca74f0f80c51c6511b9ab4c03d552 (diff) | |
| download | coreboot-a7b296d450c5d948b95c1342f726334b4e5a4c68.tar.xz | |
Fix warnings in coreboot utilities.
- Fix some poor programming practice (breaks of strict aliasing as well
as not checking the return value of read)
- Use PRIx64 instead of %llx to prevent compilation warnings with both
32bit and 64bit compilers
- Use same compiler command options when linking inteltool and when
detecting libpci for inteltool
Change-Id: I08b2e8d1bbc908f6b1f26d25cb3a4b03d818e124
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/752
Tested-by: build bot (Jenkins)
Reviewed-by: Mathias Krause <minipli@googlemail.com>
Diffstat (limited to 'util/nvramtool')
| -rw-r--r-- | util/nvramtool/cli/nvramtool.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/util/nvramtool/cli/nvramtool.c b/util/nvramtool/cli/nvramtool.c index 11a1a702af..bcb10bbf34 100644 --- a/util/nvramtool/cli/nvramtool.c +++ b/util/nvramtool/cli/nvramtool.c @@ -143,7 +143,11 @@ int main(int argc, char *argv[]) if (fd_stat.st_size < 128) { lseek(fd, 127, SEEK_SET); - write(fd, "\0", 1); + if (write(fd, "\0", 1) != 1) { + fprintf(stderr, "Unable to extended '%s' to its full size.\n", + nvramtool_op_modifiers[NVRAMTOOL_MOD_USE_CMOS_FILE].param); + exit(1); + } fsync(fd); } |