summaryrefslogtreecommitdiff
path: root/util
diff options
context:
space:
mode:
authorStefan Tauner <stefan.tauner@gmx.at>2018-08-01 06:57:36 +0200
committerNico Huber <nico.h@gmx.de>2018-08-14 07:51:36 +0000
commitb75a08b1992902d1c2895e093b5d08d6e36211c2 (patch)
tree372ce2f1905ff580a5f649db187e7e06b3a9d939 /util
parenteceba31c7f8a4bb115cf48e098e0a50edf3546b4 (diff)
downloadcoreboot-b75a08b1992902d1c2895e093b5d08d6e36211c2.tar.xz
xgcc: fix grouping of conditions in buildgcc for Ada
No idea where the escaped parentheses come from but they are no good. Without this patch I see errors with bash and dash: ./buildgcc: line 1198: (: command not found ./buildgcc: line 1199: (: command not found The patch uses curly brackets for grouping since they don't launch a subshell - unlike using unescaped parentheses which would work too. shellcheck is happy with either variant (and the original one(!)). Change-Id: I44fbc659f5b54515e43e85680b1ab0a824b781a7 Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at> Reviewed-on: https://review.coreboot.org/27771 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'util')
-rwxr-xr-xutil/crossgcc/buildgcc6
1 files changed, 3 insertions, 3 deletions
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 5823707acf..08ba3c171d 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -1195,9 +1195,9 @@ fi
if ada_requested; then
if have_gnat; then
if [ "$BOOTSTRAP" != 1 ] && \
- \( [ "$(hostcc_major)" -lt 4 ] || \
- \( [ "$(hostcc_major)" -eq 4 ] && \
- [ "$(hostcc_minor)" -lt 9 ] \) \) ]
+ { [ "$(hostcc_major)" -lt 4 ] || \
+ { [ "$(hostcc_major)" -eq 4 ] && \
+ [ "$(hostcc_minor)" -lt 9 ] ; } ; }
then
printf "\n${red}WARNING${NC}\n"
printf "Building the Ada compiler (GNAT $(buildcc_version)) with a host compiler older\n"