diff options
author | Martin Roth <martinroth@google.com> | 2016-01-31 15:17:34 -0700 |
---|---|---|
committer | Martin Roth <martinroth@google.com> | 2016-02-10 17:17:56 +0100 |
commit | 5a70d6bdf2e70b29740a36061321af59b3005f85 (patch) | |
tree | 4b50ca5d7d0ebd60ea8092a1c087854927305b59 /util | |
parent | 9e620eaff4c50ead711d726a764966d04d00c177 (diff) | |
download | coreboot-5a70d6bdf2e70b29740a36061321af59b3005f85.tar.xz |
kconfig_lint: update kconfig lint shell scripts
- Add lint-stable script with just error checking
- Enable warnings in addition to errors in non-stable test.
- Use git grep if the code is in a git repo now that exclusions are
working.
- Check for perl, and ask the user to install it if it isn't
available.
Change-Id: Ie60d21f4ef8a61d879f116eb2056eb805b0a55f2
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/13542
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'util')
-rwxr-xr-x | util/lint/lint-008-kconfig | 16 | ||||
-rwxr-xr-x | util/lint/lint-stable-008-kconfig | 30 |
2 files changed, 44 insertions, 2 deletions
diff --git a/util/lint/lint-008-kconfig b/util/lint/lint-008-kconfig index 16ae251184..d3da17ea5d 100755 --- a/util/lint/lint-008-kconfig +++ b/util/lint/lint-008-kconfig @@ -12,7 +12,19 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # -# DESCR: check Kconfig files +# DESCR: check Kconfig files for warnings and errors LC_ALL=C export LC_ALL -env perl util/lint/kconfig_lint --no_git_grep --warnings_off + +# Verify that the test can run, tell users the issue +if [ -z "$(command -v perl)" ]; then + echo "The kconfig lint tool uses perl. Please install it to run this test." +fi + +# If coreboot is in a git repo, use git grep to check as it will ignore any +# files in the tree that aren't checked into git +if [ -n "$(command -v git)" ] && [ -e ".git" ]; then + env perl util/lint/kconfig_lint +else + env perl util/lint/kconfig_lint --no_git_grep +fi diff --git a/util/lint/lint-stable-008-kconfig b/util/lint/lint-stable-008-kconfig new file mode 100755 index 0000000000..986fdc9742 --- /dev/null +++ b/util/lint/lint-stable-008-kconfig @@ -0,0 +1,30 @@ +#!/bin/sh +# This file is part of the coreboot project. +# +# Copyright 2016 Google Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# DESCR: check Kconfig files for errors + +LC_ALL=C export LC_ALL + +# Verify that the test can run, tell users the issue +if [ -z "$(command -v perl)" ]; then + echo "The kconfig lint tool uses perl. Please install it to run this test." +fi + +# If coreboot is in a git repo, use git grep to check as it will ignore any +# files in the tree that aren't checked into git +if [ -n "$(command -v git)" ] && [ -e ".git" ]; then + env perl util/lint/kconfig_lint --warnings_off +else + env perl util/lint/kconfig_lint --no_git_grep --warnings_off +fi |