summaryrefslogtreecommitdiff
path: root/util
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@chromium.org>2015-06-12 11:04:49 +0200
committerPatrick Georgi <pgeorgi@google.com>2015-06-12 23:16:01 +0200
commit2d119a3f01eee6c4e86248b17b4c9ce14ab77836 (patch)
tree7045d79b7a0f41cd0073cbdfe1a8bd678412938d /util
parentf75c3b4b6ad4868f08f374bd64cc88eb25a8c966 (diff)
downloadcoreboot-2d119a3f01eee6c4e86248b17b4c9ce14ab77836.tar.xz
bimgtool: initialize data header
Otherwise dummy contains uninitialized data, which leads to non-reproducible builds (and a leak of 4 bytes of stack data). Change-Id: Iaaf846580ec436fdd4f0800c7576b544f50d6ae0 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-on: http://review.coreboot.org/10524 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'util')
-rw-r--r--util/bimgtool/bimgtool.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/bimgtool/bimgtool.c b/util/bimgtool/bimgtool.c
index a970234ffe..505bf7d8cc 100644
--- a/util/bimgtool/bimgtool.c
+++ b/util/bimgtool/bimgtool.c
@@ -160,7 +160,7 @@ static const struct crc_t crc_type = {
static int write_binary(FILE *out, FILE *in, struct bimg_header *hdr)
{
static uint8_t file_buf[MAX_RECORD_BYTES];
- struct bimg_data_header data_hdr;
+ struct bimg_data_header data_hdr = { 0 };
size_t n_written;
data_hdr.dest_addr = hdr->entry_addr;