summaryrefslogtreecommitdiff
path: root/util
diff options
context:
space:
mode:
authorPaul Menzel <paulepanter@users.sourceforge.net>2013-04-05 00:12:21 +0200
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-04-05 20:17:03 +0200
commit5f3754e66dbe3b04c71c19fb106a92b30d475ab4 (patch)
tree1fa0cf10fecb9d08af277905176accb6af14b5f7 /util
parent72ef8881a319de48464e640ccd37e8e282320284 (diff)
downloadcoreboot-5f3754e66dbe3b04c71c19fb106a92b30d475ab4.tar.xz
inteltool: cpu.c: Use conversion specifier `u` for unsigned integers
Cppcheck [1], a static code analysis tool, warns about the following. $ cppcheck --version Cppcheck 1.59 $ cppcheck --enable=all . […] Checking cpu.c... [cpu.c:951]: (warning) %d in format string (no. 1) requires a signed integer given in the argument list. [cpu.c:962]: (warning) %d in format string (no. 1) requires a signed integer given in the argument list. […] And indeed, `core` is an unsigned integer and `man 3 printf` tells the following about conversion specifiers. d, i The int argument is converted to signed decimal notation. […] o, u, x, X The unsigned int argument is converted to unsigned octal (o), unsigned decimal (u), or unsigned hexadecimal (x and X) notation. So use `u` and Cppcheck does not complain anymore. [1] http://cppcheck.sourceforge.net/ Change-Id: If8dd8d0efe75fcb4af2502ae5100e3f2062649e4 Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-on: http://review.coreboot.org/3026 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'util')
-rw-r--r--util/inteltool/cpu.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c
index e73f0963de..80e1ed69c3 100644
--- a/util/inteltool/cpu.c
+++ b/util/inteltool/cpu.c
@@ -948,7 +948,7 @@ int print_intel_core_msrs(void)
#ifndef __DARWIN__
char msrfilename[64];
memset(msrfilename, 0, 64);
- sprintf(msrfilename, "/dev/cpu/%d/msr", core);
+ sprintf(msrfilename, "/dev/cpu/%u/msr", core);
fd_msr = open(msrfilename, O_RDWR);
@@ -959,7 +959,7 @@ int print_intel_core_msrs(void)
break;
#endif
if (cpu->num_per_core_msrs)
- printf("\n====================== UNIQUE MSRs (core %d) ======================\n", core);
+ printf("\n====================== UNIQUE MSRs (core %u) ======================\n", core);
for (i = 0; i < cpu->num_per_core_msrs; i++) {
msr = rdmsr(cpu->per_core_msrs[i].number);