diff options
| author | Nico Huber <nico.huber@secunet.com> | 2017-01-17 13:01:25 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-01-18 17:43:20 +0100 |
| commit | 607796a4ff169f375e63853713cfeef0a89a0b2c (patch) | |
| tree | 14d6d0aa02392403b8d124b04816272709337ac9 /util | |
| parent | 404f8ef420421c4587a4b55c705b4a4046cec1aa (diff) | |
| download | coreboot-607796a4ff169f375e63853713cfeef0a89a0b2c.tar.xz | |
cbfstool: Don't use le32toh(), it's non-standard
It's a BSD function, also, we missed to include `endian.h`.
Just including `endian.h` doesn't fix the problem for everyone.
Instead of digging deeper, just use our own endian-conversion from
`commonlib`.
Change-Id: Ia781b2258cafb0bcbe8408752a133cd28a888786
Reported-by: Werner Zeh <werner.zeh@siemens.com>
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/18157
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Diffstat (limited to 'util')
| -rw-r--r-- | util/cbfstool/cbfstool.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index 9b5343eb17..cc317515f7 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -30,6 +30,7 @@ #include "fit.h" #include "partitioned_file.h" #include <commonlib/fsp.h> +#include <commonlib/endian.h> #define SECTION_WITH_FIT_TABLE "BOOTBLOCK" @@ -445,8 +446,8 @@ static int cbfstool_convert_raw(struct buffer *buffer, decompressed_size = buffer->size; if (param.precompression) { - param.compression = le32toh(((uint32_t *)buffer->data)[0]); - decompressed_size = le32toh(((uint32_t *)buffer->data)[1]); + param.compression = read_le32(buffer->data); + decompressed_size = read_le32(buffer->data + sizeof(uint32_t)); compressed_size = buffer->size - 8; compressed = malloc(compressed_size); if (!compressed) |