summaryrefslogtreecommitdiff
path: root/util
diff options
context:
space:
mode:
authorDan Elkouby <streetwalrus@codewalr.us>2017-01-16 20:04:51 +0200
committerMartin Roth <martinroth@google.com>2017-01-20 17:22:54 +0100
commite8ad3c7b954b81a26073c5a4d529034db993db0e (patch)
tree487d420fa5413c1e85e82b9dad94480d4cbaf8f8 /util
parent26949e65af2860544983e87314c66e68d4e18142 (diff)
downloadcoreboot-e8ad3c7b954b81a26073c5a4d529034db993db0e.tar.xz
util/intelmetool: Try to activate the ME before scanning PCIe for it
When the ME is hidden (most likely because it was disabled), it cannot be found until activate_me() is called. Change-Id: Ie1f65f61eb131577d7254af582e2709660f4da27 Signed-off-by: Dan Elkouby <streetwalrus@codewalr.us> Reviewed-on: https://review.coreboot.org/18149 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'util')
-rw-r--r--util/intelmetool/intelmetool.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c
index 7ffd5359b3..70b23fbec2 100644
--- a/util/intelmetool/intelmetool.c
+++ b/util/intelmetool/intelmetool.c
@@ -68,7 +68,7 @@ static void rehide_me() {
printf("Re-hiding MEI device...");
fd2 = *(uint32_t *)(rcba + FD2);
*(uint32_t *)(rcba + FD2) = fd2 | 0x2;
- printf("done, ");
+ printf("done\n");
}
}
@@ -231,12 +231,12 @@ static void dump_me_info() {
exit(1);
}
- dev = pci_me_interface_scan(&name);
- if (!dev) {
+ if (activate_me()) {
exit(1);
}
- if (activate_me()) {
+ dev = pci_me_interface_scan(&name);
+ if (!dev) {
exit(1);
}