summaryrefslogtreecommitdiff
path: root/src/cpu
diff options
context:
space:
mode:
Diffstat (limited to 'src/cpu')
-rw-r--r--src/cpu/x86/mp_init.c15
-rw-r--r--src/cpu/x86/pae/pgtbl.c4
2 files changed, 16 insertions, 3 deletions
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index 8957515540..b7b8fe2afa 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -870,13 +870,20 @@ static int run_ap_work(struct mp_callback *val, long expire_us)
int i;
int cpus_accepted;
struct stopwatch sw;
- int cur_cpu = cpu_index();
+ int cur_cpu;
if (!CONFIG(PARALLEL_MP_AP_WORK)) {
printk(BIOS_ERR, "APs already parked. PARALLEL_MP_AP_WORK not selected.\n");
return -1;
}
+ cur_cpu = cpu_index();
+
+ if (cur_cpu < 0) {
+ printk(BIOS_ERR, "Invalid CPU index.\n");
+ return -1;
+ }
+
/* Signal to all the APs to run the func. */
for (i = 0; i < ARRAY_SIZE(ap_callbacks); i++) {
if (cur_cpu == i)
@@ -918,6 +925,12 @@ static void ap_wait_for_instruction(void)
return;
cur_cpu = cpu_index();
+
+ if (cur_cpu < 0) {
+ printk(BIOS_ERR, "Invalid CPU index.\n");
+ return;
+ }
+
per_cpu_slot = &ap_callbacks[cur_cpu];
while (1) {
diff --git a/src/cpu/x86/pae/pgtbl.c b/src/cpu/x86/pae/pgtbl.c
index 062ee402f1..9c921342f1 100644
--- a/src/cpu/x86/pae/pgtbl.c
+++ b/src/cpu/x86/pae/pgtbl.c
@@ -116,12 +116,12 @@ void *map_2M_page(unsigned long page)
static struct pg_table pgtbl[CONFIG_MAX_CPUS]
__attribute__((aligned(4096)));
static unsigned long mapped_window[CONFIG_MAX_CPUS];
- unsigned long index;
+ int index;
unsigned long window;
void *result;
int i;
index = cpu_index();
- if (index >= CONFIG_MAX_CPUS)
+ if (index < 0)
return MAPPING_ERROR;
window = page >> 10;
if (window != mapped_window[index]) {