From 005e25de0fe79d3aa72062279b9642d21cc9916c Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Sat, 26 Oct 2019 19:28:45 +0200 Subject: soc/intel/common/ebda: Drop code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is no need to use EBDA to pass cbmem_top from romstage to later stages. Change-Id: I46e2459ff3c785f530cabc5930004ef920ffc89a Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/36362 Tested-by: build bot (Jenkins) Reviewed-by: Michael Niewöhner Reviewed-by: Nico Huber --- src/soc/intel/cannonlake/include/soc/ebda.h | 26 --------------- src/soc/intel/common/block/ebda/Kconfig | 5 --- src/soc/intel/common/block/ebda/Makefile.inc | 3 -- src/soc/intel/common/block/ebda/ebda.c | 37 --------------------- .../intel/common/block/include/intelblocks/ebda.h | 38 ---------------------- src/soc/intel/icelake/include/soc/ebda.h | 26 --------------- src/soc/intel/skylake/include/soc/ebda.h | 26 --------------- 7 files changed, 161 deletions(-) delete mode 100644 src/soc/intel/cannonlake/include/soc/ebda.h delete mode 100644 src/soc/intel/common/block/ebda/Kconfig delete mode 100644 src/soc/intel/common/block/ebda/Makefile.inc delete mode 100644 src/soc/intel/common/block/ebda/ebda.c delete mode 100644 src/soc/intel/common/block/include/intelblocks/ebda.h delete mode 100644 src/soc/intel/icelake/include/soc/ebda.h delete mode 100644 src/soc/intel/skylake/include/soc/ebda.h diff --git a/src/soc/intel/cannonlake/include/soc/ebda.h b/src/soc/intel/cannonlake/include/soc/ebda.h deleted file mode 100644 index 4ed6566838..0000000000 --- a/src/soc/intel/cannonlake/include/soc/ebda.h +++ /dev/null @@ -1,26 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2017 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef SOC_EBDA_H -#define SOC_EBDA_H - -#include - -struct ebda_config { - uint32_t signature; /* EBDA signature */ - uint32_t cbmem_top; /* coreboot memory start */ -}; - -#endif diff --git a/src/soc/intel/common/block/ebda/Kconfig b/src/soc/intel/common/block/ebda/Kconfig deleted file mode 100644 index 67c7b48033..0000000000 --- a/src/soc/intel/common/block/ebda/Kconfig +++ /dev/null @@ -1,5 +0,0 @@ -config SOC_INTEL_COMMON_BLOCK_EBDA - bool - select EARLY_EBDA_INIT - help - Intel Processor common EBDA library support diff --git a/src/soc/intel/common/block/ebda/Makefile.inc b/src/soc/intel/common/block/ebda/Makefile.inc deleted file mode 100644 index beeba5176a..0000000000 --- a/src/soc/intel/common/block/ebda/Makefile.inc +++ /dev/null @@ -1,3 +0,0 @@ -romstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_EBDA) += ebda.c -ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_EBDA) += ebda.c -postcar-$(CONFIG_SOC_INTEL_COMMON_BLOCK_EBDA) += ebda.c diff --git a/src/soc/intel/common/block/ebda/ebda.c b/src/soc/intel/common/block/ebda/ebda.c deleted file mode 100644 index 072023cd16..0000000000 --- a/src/soc/intel/common/block/ebda/ebda.c +++ /dev/null @@ -1,37 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2017 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include -#include -#include - -void initialize_ebda_area(void) -{ - struct ebda_config ebda_cfg; - - /* Initialize EBDA area early during romstage. */ - setup_default_ebda(); - ebda_cfg.signature = EBDA_SIGNATURE; - fill_memmap_ebda(&ebda_cfg); - write_ebda_data(&ebda_cfg, sizeof(ebda_cfg)); -} - -void retrieve_ebda_object(struct ebda_config *cfg) -{ - read_ebda_data(cfg, sizeof(*cfg)); - - if (cfg->signature != EBDA_SIGNATURE) - memset(cfg, 0, sizeof(*cfg)); -} diff --git a/src/soc/intel/common/block/include/intelblocks/ebda.h b/src/soc/intel/common/block/include/intelblocks/ebda.h deleted file mode 100644 index 48904f4705..0000000000 --- a/src/soc/intel/common/block/include/intelblocks/ebda.h +++ /dev/null @@ -1,38 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2017 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef SOC_INTEL_COMMON_BLOCK_EBDA_H -#define SOC_INTEL_COMMON_BLOCK_EBDA_H - -#define EBDA_SIGNATURE 0xebdaebda - -/* EBDA structure */ -struct ebda_config { - uint32_t signature; /* EBDA signature */ - uint32_t cbmem_top; /* coreboot memory start */ -}; - -/* Initialize EBDA and store structure into EBDA area */ -void initialize_ebda_area(void); - -/* - * Fill the ebda object pointed to by cfg. Object will be zero filled - * if signature check fails. */ -void retrieve_ebda_object(struct ebda_config *cfg); - -/* API for filling ebda with data in romstage */ -void fill_memmap_ebda(struct ebda_config *cfg); - -#endif diff --git a/src/soc/intel/icelake/include/soc/ebda.h b/src/soc/intel/icelake/include/soc/ebda.h deleted file mode 100644 index 5cb5cdc004..0000000000 --- a/src/soc/intel/icelake/include/soc/ebda.h +++ /dev/null @@ -1,26 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2018 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef SOC_EBDA_H -#define SOC_EBDA_H - -#include - -struct ebda_config { - uint32_t signature; /* EBDA signature */ - uint32_t cbmem_top; /* coreboot memory start */ -}; - -#endif diff --git a/src/soc/intel/skylake/include/soc/ebda.h b/src/soc/intel/skylake/include/soc/ebda.h deleted file mode 100644 index 4ed6566838..0000000000 --- a/src/soc/intel/skylake/include/soc/ebda.h +++ /dev/null @@ -1,26 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2017 Intel Corporation. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#ifndef SOC_EBDA_H -#define SOC_EBDA_H - -#include - -struct ebda_config { - uint32_t signature; /* EBDA signature */ - uint32_t cbmem_top; /* coreboot memory start */ -}; - -#endif -- cgit v1.2.3