From 0c590f064e040e0f75abdc9e816ef1d21bf8b437 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Tue, 11 Dec 2018 19:21:45 +0100 Subject: pci_drivers/cpu_drivers: Fix constructed arrays on x86_64 The __pci_driver and __cpu_driver uses variable length arrays which are constructed by the linker at build-time. The linker always place the structs at 16-byte boundary, as per "System V ABI". That's not a problem on x86, as the struct is exactly 16 Bytes in size. On other platforms, like x86_64 it breaks, because the default data alignment isn't SysV compatible. Set -malign-data=abi to make x86_64 gcc use the SysV psABI. Fixes broken __pci_driver and __cpu_driver on x86_64. Change-Id: I2491d47ed03dcfd8db110dfb181b2c5281449591 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/30116 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- util/xcompile/xcompile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 0fefff2f5a..4a29cdd647 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -238,7 +238,7 @@ EOF # to use i586 instead. if [ "${TARCH}" = "x86_64" ]; then cat <