From 0e560e7015fffa209a3a5e5db0f8d786030cf2c0 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Thu, 11 Feb 2021 10:10:57 -0700 Subject: soc/amd: Move acpi_fill_mcfg into common/blocks/acpi This is common between stoney, picasso, and cezanne. Signed-off-by: Raul E Rangel Change-Id: I5fb40e8c6817773212c5fbd66c5c06bd2bae1eda Reviewed-on: https://review.coreboot.org/c/coreboot/+/50556 Reviewed-by: Mathew King Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/acpi/tables.c | 12 ++++++++++++ src/soc/amd/picasso/acpi.c | 12 ------------ src/soc/amd/stoneyridge/northbridge.c | 12 ------------ 3 files changed, 12 insertions(+), 24 deletions(-) diff --git a/src/soc/amd/common/block/acpi/tables.c b/src/soc/amd/common/block/acpi/tables.c index fd1f37f872..f941bc94a0 100644 --- a/src/soc/amd/common/block/acpi/tables.c +++ b/src/soc/amd/common/block/acpi/tables.c @@ -11,3 +11,15 @@ unsigned long southbridge_write_acpi_tables(const struct device *device, { return acpi_write_hpet(device, current, rsdp); } + +unsigned long acpi_fill_mcfg(unsigned long current) +{ + + current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current, + CONFIG_MMCONF_BASE_ADDRESS, + 0, + 0, + CONFIG_MMCONF_BUS_NUMBER - 1); + + return current; +} diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index f1698442fa..5cee2039e8 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -29,18 +29,6 @@ #include #include "chip.h" -unsigned long acpi_fill_mcfg(unsigned long current) -{ - - current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current, - CONFIG_MMCONF_BASE_ADDRESS, - 0, - 0, - CONFIG_MMCONF_BUS_NUMBER - 1); - - return current; -} - unsigned long acpi_fill_madt(unsigned long current) { const struct soc_amd_picasso_config *cfg = config_of_soc(); diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 25e55a6bb5..61d89444b3 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -162,18 +162,6 @@ static void northbridge_init(struct device *dev) setup_ioapic((u8 *)IO_APIC2_ADDR, CONFIG_MAX_CPUS+1); } -unsigned long acpi_fill_mcfg(unsigned long current) -{ - - current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current, - CONFIG_MMCONF_BASE_ADDRESS, - 0, - 0, - CONFIG_MMCONF_BUS_NUMBER - 1); - - return current; -} - static unsigned long acpi_fill_hest(acpi_hest_t *hest) { void *addr, *current; -- cgit v1.2.3