From 3130a93bfa953011fed7429b17d3727abd3b4100 Mon Sep 17 00:00:00 2001 From: li feng Date: Thu, 24 May 2018 14:27:58 -0700 Subject: skylake: Remove "IshEnable" Remove "IshEnable" from soc_intel_skylake_config since it's not used anymore. Enable/disable ISH by checking if ISH device is turned on or not. Refer to https://review.coreboot.org/#/c/coreboot/+/26485/. BUG=b:79244403 BRANCH=none TEST=Built. Change-Id: I4d2889af118659852431c87cb516fd19b577efc5 Signed-off-by: li feng Reviewed-on: https://review.coreboot.org/26521 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/mainboard/google/chell/devicetree.cb | 1 - src/mainboard/google/eve/devicetree.cb | 1 - src/mainboard/google/fizz/devicetree.cb | 1 - src/mainboard/google/glados/devicetree.cb | 1 - src/mainboard/google/poppy/variants/baseboard/devicetree.cb | 1 - src/mainboard/google/poppy/variants/nami/devicetree.cb | 1 - src/mainboard/google/poppy/variants/nautilus/devicetree.cb | 1 - src/mainboard/google/poppy/variants/nocturne/devicetree.cb | 1 - src/mainboard/google/poppy/variants/soraka/devicetree.cb | 1 - src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb | 1 - src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb | 1 - src/soc/intel/skylake/chip.h | 3 --- 12 files changed, 14 deletions(-) diff --git a/src/mainboard/google/chell/devicetree.cb b/src/mainboard/google/chell/devicetree.cb index 4ad8036cfa..b9d072f8a1 100644 --- a/src/mainboard/google/chell/devicetree.cb +++ b/src/mainboard/google/chell/devicetree.cb @@ -42,7 +42,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "0" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index a812c0814f..16bfc47a59 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -38,7 +38,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "0" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb index 0ac403efa5..281d65ce87 100644 --- a/src/mainboard/google/fizz/devicetree.cb +++ b/src/mainboard/google/fizz/devicetree.cb @@ -73,7 +73,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "0" register "ScsEmmcHs400Enabled" = "0" register "ScsSdCardEnabled" = "2" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/glados/devicetree.cb b/src/mainboard/google/glados/devicetree.cb index 386e3dbb6d..75e116c9eb 100644 --- a/src/mainboard/google/glados/devicetree.cb +++ b/src/mainboard/google/glados/devicetree.cb @@ -42,7 +42,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "2" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 6fe949ffc2..ad1e628bdd 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -45,7 +45,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "2" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 54d989f564..3835573720 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -44,7 +44,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "0" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb index b2617e54f6..37edd8af91 100644 --- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb @@ -45,7 +45,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "2" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index d8151431e4..5e1b7aa41c 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -45,7 +45,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "0" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index 762955df44..ddf74a15f3 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -45,7 +45,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "1" register "ScsEmmcHs400Enabled" = "1" register "ScsSdCardEnabled" = "2" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb index 08ba50607b..a4fd502dbe 100644 --- a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb @@ -56,7 +56,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "0" register "ScsEmmcHs400Enabled" = "0" register "ScsSdCardEnabled" = "0" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb index 4ba6ccddba..7ff3dad399 100644 --- a/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb +++ b/src/mainboard/purism/librem_skl/variants/librem15v3/devicetree.cb @@ -56,7 +56,6 @@ chip soc/intel/skylake register "ScsEmmcEnabled" = "0" register "ScsEmmcHs400Enabled" = "0" register "ScsSdCardEnabled" = "0" - register "IshEnable" = "0" register "PttSwitch" = "0" register "InternalGfx" = "1" register "SkipExtGfxScan" = "1" diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index 9f78e5c3b8..a6e03ca435 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -287,9 +287,6 @@ struct soc_intel_skylake_config { u8 ScsEmmcHs400Enabled; u8 ScsSdCardEnabled; - /* Integrated Sensor */ - u8 IshEnable; - u8 PttSwitch; u8 HeciTimeouts; u8 HsioMessaging; -- cgit v1.2.3