From 35abe73e48ad27144ef8700a2199f7b2cdc6de61 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Thu, 6 Jun 2019 15:41:27 +0200 Subject: mb/lenovo/t430: Fix Dual Graphics * Select ONBOARD_VGA_IS_PRIMARY in driver/lenovo/hybrid_graphics to fix disabling iGPU in 'Dual Graphics' on Lenovo T430. * Remove ONBOARD_VGA_IS_PRIMARY in mainboards that already select DRIVERS_LENOVO_HYBRID_GRAPHICS. Change-Id: I6594fbb957c9a8135fe670d38b5755adf29d2dff Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/33254 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/drivers/lenovo/hybrid_graphics/Kconfig | 2 ++ src/mainboard/lenovo/t400/Kconfig | 4 ---- src/mainboard/lenovo/t420/Kconfig | 4 ---- src/mainboard/lenovo/t420s/Kconfig | 4 ---- src/mainboard/lenovo/t520/Kconfig | 4 ---- src/mainboard/lenovo/t530/Kconfig | 4 ---- 6 files changed, 2 insertions(+), 20 deletions(-) diff --git a/src/drivers/lenovo/hybrid_graphics/Kconfig b/src/drivers/lenovo/hybrid_graphics/Kconfig index 389dfb919f..222d4fd2f2 100644 --- a/src/drivers/lenovo/hybrid_graphics/Kconfig +++ b/src/drivers/lenovo/hybrid_graphics/Kconfig @@ -1,3 +1,5 @@ config DRIVERS_LENOVO_HYBRID_GRAPHICS bool default n + # for dual graphics we need to set this + select ONBOARD_VGA_IS_PRIMARY diff --git a/src/mainboard/lenovo/t400/Kconfig b/src/mainboard/lenovo/t400/Kconfig index 2bd67c28bc..2caf1d3b65 100644 --- a/src/mainboard/lenovo/t400/Kconfig +++ b/src/mainboard/lenovo/t400/Kconfig @@ -62,10 +62,6 @@ config CBFS_SIZE hex default 0x200000 -config ONBOARD_VGA_IS_PRIMARY - bool - default y - config INTEL_GMA_VBT_FILE default "src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/data.vbt" diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index 02bcc4f4a4..5148604a68 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -75,8 +75,4 @@ config VGA_BIOS_ID string default "8086,0126" -config ONBOARD_VGA_IS_PRIMARY - bool - default y - endif # BOARD_LENOVO_T420 diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index 60735b049d..190f35e4b5 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -74,8 +74,4 @@ config VGA_BIOS_ID string default "8086,0126" -config ONBOARD_VGA_IS_PRIMARY - bool - default y - endif # BOARD_LENOVO_T420S diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index e847f8e39d..d4934d6685 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -84,8 +84,4 @@ config VGA_BIOS_FILE string default "pci8086,0126.rom" -config ONBOARD_VGA_IS_PRIMARY - bool - default y - endif diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 5b5b7ffa49..5fd9118e94 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -62,8 +62,4 @@ config VGA_BIOS_FILE default "pci8086,0106.rom" if BOARD_LENOVO_T530 default "pci8086,0166.rom" if BOARD_LENOVO_W530 -config ONBOARD_VGA_IS_PRIMARY - bool - default y - endif -- cgit v1.2.3