From 374d7c2e94ce4bc8520368ee0f0aa9d0e44a56ca Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 27 Mar 2020 20:56:40 +0100 Subject: Do not select USE_BLOBS The `USE_BLOBS` config only exists for idealistic reasons. If we would allow us to use blobs by default, we wouldn't need that option and could just always do it. It's generally debatable for the project as a whole, but not per board/subject. Change-Id: I8591862699aef02e5a4ede32655fc82c44c97555 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/39884 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Angel Pons Reviewed-by: Felix Held --- src/mainboard/pcengines/apu2/Kconfig | 1 - src/mainboard/system76/lemp9/Kconfig | 1 - src/mainboard/up/squared/Kconfig | 1 - src/security/intel/stm/Kconfig | 1 - 4 files changed, 4 deletions(-) diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index 1915cc22d7..4321c5cfef 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -26,7 +26,6 @@ config BOARD_SPECIFIC_OPTIONS select HAVE_MP_TABLE select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_8192 - select USE_BLOBS select GENERIC_SPD_BIN select MAINBOARD_HAS_LPC_TPM select SEABIOS_ADD_SERCON_PORT_FILE if PAYLOAD_SEABIOS diff --git a/src/mainboard/system76/lemp9/Kconfig b/src/mainboard/system76/lemp9/Kconfig index d8146332fe..cc21ca9575 100644 --- a/src/mainboard/system76/lemp9/Kconfig +++ b/src/mainboard/system76/lemp9/Kconfig @@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP - select USE_BLOBS select USE_LEGACY_8254_TIMER # Fix failure to boot GRUB config MAINBOARD_DIR diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig index 542e8c3c20..5104713022 100644 --- a/src/mainboard/up/squared/Kconfig +++ b/src/mainboard/up/squared/Kconfig @@ -2,7 +2,6 @@ if BOARD_UP_SQUARED config BOARD_SPECIFIC_OPTIONS def_bool y - select USE_BLOBS select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select INTEL_GMA_HAVE_VBT diff --git a/src/security/intel/stm/Kconfig b/src/security/intel/stm/Kconfig index 618217f686..f7dd363faa 100644 --- a/src/security/intel/stm/Kconfig +++ b/src/security/intel/stm/Kconfig @@ -3,7 +3,6 @@ config STM default n depends on ENABLE_VMX depends on SMM_TSEG - select USE_BLOBS help Enabling the STM will load a simple hypervisor into SMM that will -- cgit v1.2.3