From 524bcbb494d5486470b993d7d717234d5781da03 Mon Sep 17 00:00:00 2001 From: Andrew McRae Date: Thu, 19 Sep 2019 16:55:52 +1000 Subject: drivers/wifi/generic.c: Upper case the AML WiFi name as required by spec ACPI 6.3, ASL 20.2.2 (Name Objects Encoding) states: LeadNameChar := 'A'-'Z' | '_' NameChar := DigitChar | LeadNameChar Hence, the Intel WiFi names generated in ASL are required to be upper-cased letters. BUG=b:141206986 TEST=Reflash and confirmed SSDT table has correct name. Change-Id: I803b9bc81804eec7bd5220b9dbc6ddd0bb0ecbcc Signed-off-by: Andrew McRae Reviewed-on: https://review.coreboot.org/c/coreboot/+/35466 Reviewed-by: Edward O'Callaghan Tested-by: build bot (Jenkins) --- src/drivers/wifi/generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/drivers/wifi/generic.c b/src/drivers/wifi/generic.c index b593ffe8bc..fc88f4a629 100644 --- a/src/drivers/wifi/generic.c +++ b/src/drivers/wifi/generic.c @@ -239,7 +239,8 @@ const char *generic_wifi_acpi_name(const struct device *dev) { static char wifi_acpi_name[WIFI_ACPI_NAME_MAX_LEN]; - snprintf(wifi_acpi_name, sizeof(wifi_acpi_name), "WF%02x", + /* ACPI 6.3, ASL 20.2.2: (Name Objects Encoding). */ + snprintf(wifi_acpi_name, sizeof(wifi_acpi_name), "WF%02X", (dev_path_encode(dev) & 0xff)); return wifi_acpi_name; } -- cgit v1.2.3