From 84fbc30e928d28fba2f3a25f6ccea3a831dce648 Mon Sep 17 00:00:00 2001 From: Naresh G Solanki Date: Mon, 15 Oct 2018 15:37:15 +0530 Subject: soc/intel/skylake: Prevent disabling of TCO In Skylake/Kabylake, if ACPI PM timer is disabled then TCO also gets disabled & vice versa. FSP default config for EnableTcoTimer is disabled, this caused ACPI PM timer & TCO to be disabled by FSP even when config PmTimerDisable = 0. Thus update FSPS UPD EnableTcoTimer in accordance to devicetree config PmTimerDisable. BUG=None TEST= Build for Soraka with PmTimerDisable=0 & check if TCO caused reboot after running shell command: cat >> /dev/watchdog0 Change-Id: Ia146761036c9dbaef3c02c9a7122ae3dcdef7bdd Signed-off-by: Naresh G Solanki Reviewed-on: https://review.coreboot.org/29108 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Rizwan Qureshi --- src/soc/intel/skylake/chip_fsp20.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c index a2a430e695..7cc6de51f7 100644 --- a/src/soc/intel/skylake/chip_fsp20.c +++ b/src/soc/intel/skylake/chip_fsp20.c @@ -369,6 +369,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd) params->SataMode = config->SataMode; params->SataSpeedLimit = config->SataSpeedLimit; params->SataPwrOptEnable = config->SataPwrOptEnable; + params->EnableTcoTimer = !config->PmTimerDisabled; tconfig->PchLockDownGlobalSmi = config->LockDownConfigGlobalSmi; tconfig->PchLockDownRtcLock = config->LockDownConfigRtcLock; -- cgit v1.2.3