From 8dd40061619913c9f7dea9a82329ae13fc73e450 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Fri, 3 Nov 2017 11:50:14 -0600 Subject: soc/amd/common: remove superfluous NULL initializers on globals Global variables that are unitialized in C programs reside in the .bss section. By definition, this section is cleared to 0. Therefore, remove the explicit NULL initialization because it's completely unnecessary. Change-Id: I9e7a5a1e2110aa48a5497ab7e2b06676dd557763 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/22313 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Marshall Dawson --- src/soc/amd/common/agesawrapper.c | 20 ++++++++++---------- src/soc/amd/common/amd_pci_util.c | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/soc/amd/common/agesawrapper.c b/src/soc/amd/common/agesawrapper.c index 0ca47df154..30c8514033 100644 --- a/src/soc/amd/common/agesawrapper.c +++ b/src/soc/amd/common/agesawrapper.c @@ -30,16 +30,16 @@ void __attribute__((weak)) OemPostParams(AMD_POST_PARAMS *PostParams) {} #ifndef __PRE_RAM__ /* ACPI table pointers returned by AmdInitLate */ -static void *DmiTable = NULL; -static void *AcpiPstate = NULL; -static void *AcpiSrat = NULL; -static void *AcpiSlit = NULL; - -static void *AcpiWheaMce = NULL; -static void *AcpiWheaCmc = NULL; -static void *AcpiAlib = NULL; -static void *AcpiIvrs = NULL; -static void *AcpiCrat = NULL; +static void *DmiTable; +static void *AcpiPstate; +static void *AcpiSrat; +static void *AcpiSlit; + +static void *AcpiWheaMce; +static void *AcpiWheaCmc; +static void *AcpiAlib; +static void *AcpiIvrs; +static void *AcpiCrat; #endif /* #ifndef __PRE_RAM__ */ AGESA_STATUS agesawrapper_amdinitreset(void) diff --git a/src/soc/amd/common/amd_pci_util.c b/src/soc/amd/common/amd_pci_util.c index 0a7c8a130b..ff9374fee0 100644 --- a/src/soc/amd/common/amd_pci_util.c +++ b/src/soc/amd/common/amd_pci_util.c @@ -22,10 +22,10 @@ #include #include -const struct pirq_struct *pirq_data_ptr = NULL; -u32 pirq_data_size = 0; -const u8 *intr_data_ptr = NULL; -const u8 *picr_data_ptr = NULL; +const struct pirq_struct *pirq_data_ptr; +u32 pirq_data_size; +const u8 *intr_data_ptr; +const u8 *picr_data_ptr; /* * Read the FCH PCI_INTR registers 0xC00/0xC01 at a -- cgit v1.2.3