From 90a9db537b68ebb85deab0eaa2f5f19467532ee2 Mon Sep 17 00:00:00 2001 From: Wim Vervoorn Date: Thu, 2 Jan 2020 11:51:48 +0100 Subject: drivers/intel/fsp1_1/logo.c: Correct check for logo_size The check to validate if the logo file was loaded correctly was incorrect. Now check the actual logo size. BUG=N/A TEST=build Change-Id: I4df2076b2f0cc371848a912c622268dfec24e2ef Signed-off-by: Wim Vervoorn Reviewed-on: https://review.coreboot.org/c/coreboot/+/38123 Tested-by: build bot (Jenkins) Reviewed-by: Frans Hendriks Reviewed-by: Nico Huber --- src/drivers/intel/fsp1_1/logo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drivers/intel/fsp1_1/logo.c b/src/drivers/intel/fsp1_1/logo.c index 23aad01c1b..b00406d2bd 100644 --- a/src/drivers/intel/fsp1_1/logo.c +++ b/src/drivers/intel/fsp1_1/logo.c @@ -26,7 +26,7 @@ const struct cbmem_entry *fsp_load_logo(UINT32 *logo_ptr, UINT32 *logo_size) if (logo_buffer) { *logo_size = cbfs_boot_load_file("logo.bmp", (void *)logo_buffer, 1 * MiB, CBFS_TYPE_RAW); - if (logo_size) + if (*logo_size) *logo_ptr = (UINT32)logo_buffer; } } -- cgit v1.2.3