From a949e3019117b6b257d674dd538ce1697e2cebcb Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Tue, 18 May 2021 10:21:56 -0600 Subject: mb/google/dedede: move discrete TPM in overridetree for lalala Move discrete TPM in the devicetree to avoid emitting the following message: "Using default TPM ACPI path: '\_SB_.PCI0.LPCB'" There is no corresonding ACPI device for 1f.5 PCI device. Therefore, move the discrete TPM to a device that has the corresponding ACPI device node. Functionality should remain the same. BUG=b:187518267 Change-Id: Ie9ec70336d5651c87f06f8b357abd1bfdb1cc06b Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/c/coreboot/+/54634 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian Reviewed-by: Aseda Aboagye --- src/mainboard/google/dedede/variants/lalala/overridetree.cb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/dedede/variants/lalala/overridetree.cb b/src/mainboard/google/dedede/variants/lalala/overridetree.cb index 5f83e4fda9..8e5239b395 100644 --- a/src/mainboard/google/dedede/variants/lalala/overridetree.cb +++ b/src/mainboard/google/dedede/variants/lalala/overridetree.cb @@ -290,13 +290,13 @@ chip soc/intel/jasperlake device i2c 29 on end end end - device pci 1e.2 off end # GSPI 0 - device pci 1f.3 on end # Intel HDA - device pci 1f.5 on + device pci 1f.0 on chip drivers/pc80/tpm device pnp 0c31.0 on end # Discrete TPM end # chip drivers/pc80/tpm - end # PCH SPI + end # PCH eSPI + device pci 1e.2 off end # GSPI 0 + device pci 1f.3 on end # Intel HDA device pci 1c.7 on chip drivers/wifi/generic register "wake" = "GPE0_DW2_03" -- cgit v1.2.3