From b74f45e9c4ae7bb504986298df8da89b6f017e65 Mon Sep 17 00:00:00 2001
From: Elyes HAOUAS <ehaouas@noos.fr>
Date: Mon, 11 May 2020 19:59:14 +0200
Subject: src: Remove unused 'include <string.h>'

Unused includes found using following commande:
diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'memcpy\|memmove\|memset\|memcmp\|memchr\|strdup\|strconcat\|strnlen\|strlen\|strchr\|strncpy\|strcpy\|strcmp\|strncmp\|strspn\|strcspn\|atol\|strrchr\|skip_atoi\|STRINGIFY' -- src/) |grep -v vendorcode |grep '<'

Change-Id: Ibaeec213b6019dfa9c45e3424b38af0e094d0c51
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41242
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Wim Vervoorn <wvervoorn@eltan.com>
---
 src/arch/x86/bootblock_normal.c                      | 1 -
 src/drivers/pc80/rtc/mc146818rtc.c                   | 1 -
 src/drivers/spi/adesto.c                             | 1 -
 src/drivers/spi/amic.c                               | 1 -
 src/drivers/spi/atmel.c                              | 1 -
 src/drivers/spi/eon.c                                | 1 -
 src/drivers/spi/gigadevice.c                         | 1 -
 src/drivers/spi/macronix.c                           | 1 -
 src/drivers/spi/spansion.c                           | 1 -
 src/drivers/spi/sst.c                                | 1 -
 src/drivers/spi/stmicro.c                            | 1 -
 src/drivers/spi/winbond.c                            | 1 -
 src/mainboard/asus/p5ql-em/acpi_tables.c             | 1 -
 src/mainboard/google/dedede/board_info.c             | 1 -
 src/mainboard/google/kukui/panel_anx7625.c           | 1 -
 src/mainboard/google/octopus/mainboard.c             | 1 -
 src/mainboard/intel/tglrvp/romstage_fsp_params.c     | 1 -
 src/mainboard/lenovo/t400/acpi_tables.c              | 1 -
 src/mainboard/lenovo/x200/acpi_tables.c              | 1 -
 src/mainboard/roda/rk9/acpi_tables.c                 | 1 -
 src/security/tpm/tspi/tspi.c                         | 1 -
 src/security/vboot/secdata_tpm.c                     | 1 -
 src/soc/intel/cannonlake/bootblock/report_platform.c | 1 -
 src/soc/intel/common/block/cse/cse_lite.c            | 1 -
 src/soc/intel/common/block/cse/disable_heci.c        | 1 -
 src/soc/intel/common/block/smbus/smbuslib.c          | 1 -
 src/soc/qualcomm/sc7180/qupv3_i2c.c                  | 1 -
 27 files changed, 27 deletions(-)

diff --git a/src/arch/x86/bootblock_normal.c b/src/arch/x86/bootblock_normal.c
index 1fb3692ddb..3fbdbec2cd 100644
--- a/src/arch/x86/bootblock_normal.c
+++ b/src/arch/x86/bootblock_normal.c
@@ -4,7 +4,6 @@
 #include <fallback.h>
 #include <program_loading.h>
 #include <stddef.h>
-#include <string.h>
 
 static const char *get_fallback(const char *stagelist)
 {
diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c
index 832d4fda2f..79bb5eb34a 100644
--- a/src/drivers/pc80/rtc/mc146818rtc.c
+++ b/src/drivers/pc80/rtc/mc146818rtc.c
@@ -9,7 +9,6 @@
 #include <option.h>
 #include <pc80/mc146818rtc.h>
 #include <rtc.h>
-#include <string.h>
 #include <cbfs.h>
 #include <security/vboot/vbnv.h>
 #include <security/vboot/vbnv_layout.h>
diff --git a/src/drivers/spi/adesto.c b/src/drivers/spi/adesto.c
index 1006de730a..6538905681 100644
--- a/src/drivers/spi/adesto.c
+++ b/src/drivers/spi/adesto.c
@@ -7,7 +7,6 @@
 
 #include <console/console.h>
 #include <commonlib/helpers.h>
-#include <string.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
 
diff --git a/src/drivers/spi/amic.c b/src/drivers/spi/amic.c
index 2929e85b8a..5e74616c88 100644
--- a/src/drivers/spi/amic.c
+++ b/src/drivers/spi/amic.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/atmel.c b/src/drivers/spi/atmel.c
index 448f9062bd..4dcc5b5bcf 100644
--- a/src/drivers/spi/atmel.c
+++ b/src/drivers/spi/atmel.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/eon.c b/src/drivers/spi/eon.c
index 6db2cd1f49..1212c6b607 100644
--- a/src/drivers/spi/eon.c
+++ b/src/drivers/spi/eon.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/gigadevice.c b/src/drivers/spi/gigadevice.c
index d1ab1a698a..6c5a167dee 100644
--- a/src/drivers/spi/gigadevice.c
+++ b/src/drivers/spi/gigadevice.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/macronix.c b/src/drivers/spi/macronix.c
index 9f918341b7..f3f7e2d24b 100644
--- a/src/drivers/spi/macronix.c
+++ b/src/drivers/spi/macronix.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/spansion.c b/src/drivers/spi/spansion.c
index fe55fe4652..fe0e265cd9 100644
--- a/src/drivers/spi/spansion.c
+++ b/src/drivers/spi/spansion.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/sst.c b/src/drivers/spi/sst.c
index 2d107dcee5..887380fdeb 100644
--- a/src/drivers/spi/sst.c
+++ b/src/drivers/spi/sst.c
@@ -8,7 +8,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/stmicro.c b/src/drivers/spi/stmicro.c
index 3477789942..4cd8c1b9a3 100644
--- a/src/drivers/spi/stmicro.c
+++ b/src/drivers/spi/stmicro.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 
 #include "spi_flash_internal.h"
 
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c
index c2b81f5388..d8d3cdc855 100644
--- a/src/drivers/spi/winbond.c
+++ b/src/drivers/spi/winbond.c
@@ -4,7 +4,6 @@
 #include <commonlib/helpers.h>
 #include <spi_flash.h>
 #include <spi-generic.h>
-#include <string.h>
 #include <delay.h>
 #include <lib.h>
 
diff --git a/src/mainboard/asus/p5ql-em/acpi_tables.c b/src/mainboard/asus/p5ql-em/acpi_tables.c
index abb544e9a9..b65ca71789 100644
--- a/src/mainboard/asus/p5ql-em/acpi_tables.c
+++ b/src/mainboard/asus/p5ql-em/acpi_tables.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <string.h>
 #include <acpi/acpigen.h>
 #include <southbridge/intel/i82801jx/nvs.h>
 
diff --git a/src/mainboard/google/dedede/board_info.c b/src/mainboard/google/dedede/board_info.c
index 38d722c16c..3289cb4ecf 100644
--- a/src/mainboard/google/dedede/board_info.c
+++ b/src/mainboard/google/dedede/board_info.c
@@ -4,7 +4,6 @@
 #include <console/console.h>
 #include <ec/google/chromeec/ec.h>
 #include <smbios.h>
-#include <string.h>
 
 int board_info_get_fw_config(uint32_t *fw_config)
 {
diff --git a/src/mainboard/google/kukui/panel_anx7625.c b/src/mainboard/google/kukui/panel_anx7625.c
index 5685661445..cae9edc041 100644
--- a/src/mainboard/google/kukui/panel_anx7625.c
+++ b/src/mainboard/google/kukui/panel_anx7625.c
@@ -6,7 +6,6 @@
 #include <edid.h>
 #include <gpio.h>
 #include <soc/i2c.h>
-#include <string.h>
 
 #include "panel.h"
 
diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c
index b7f45f6d40..e6dbd0330b 100644
--- a/src/mainboard/google/octopus/mainboard.c
+++ b/src/mainboard/google/octopus/mainboard.c
@@ -18,7 +18,6 @@
 #include <soc/nhlt.h>
 #include <soc/pci_devs.h>
 #include <stdint.h>
-#include <string.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 #include <variant/ec.h>
 #include <variant/gpio.h>
diff --git a/src/mainboard/intel/tglrvp/romstage_fsp_params.c b/src/mainboard/intel/tglrvp/romstage_fsp_params.c
index bf223824fc..d4433a1d66 100644
--- a/src/mainboard/intel/tglrvp/romstage_fsp_params.c
+++ b/src/mainboard/intel/tglrvp/romstage_fsp_params.c
@@ -4,7 +4,6 @@
 #include <fsp/api.h>
 #include <soc/romstage.h>
 #include <spd_bin.h>
-#include <string.h>
 #include <soc/meminit.h>
 #include <baseboard/variants.h>
 #include <cbfs.h>
diff --git a/src/mainboard/lenovo/t400/acpi_tables.c b/src/mainboard/lenovo/t400/acpi_tables.c
index 98eddc5660..91cf2c37ed 100644
--- a/src/mainboard/lenovo/t400/acpi_tables.c
+++ b/src/mainboard/lenovo/t400/acpi_tables.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <string.h>
 #include <arch/ioapic.h>
 #include <acpi/acpi.h>
 #include <arch/smp/mpspec.h>
diff --git a/src/mainboard/lenovo/x200/acpi_tables.c b/src/mainboard/lenovo/x200/acpi_tables.c
index 98eddc5660..91cf2c37ed 100644
--- a/src/mainboard/lenovo/x200/acpi_tables.c
+++ b/src/mainboard/lenovo/x200/acpi_tables.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <string.h>
 #include <arch/ioapic.h>
 #include <acpi/acpi.h>
 #include <arch/smp/mpspec.h>
diff --git a/src/mainboard/roda/rk9/acpi_tables.c b/src/mainboard/roda/rk9/acpi_tables.c
index 82b257628c..7cc2468b05 100644
--- a/src/mainboard/roda/rk9/acpi_tables.c
+++ b/src/mainboard/roda/rk9/acpi_tables.c
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-#include <string.h>
 #include <arch/ioapic.h>
 #include <acpi/acpi.h>
 #include <arch/smp/mpspec.h>
diff --git a/src/security/tpm/tspi/tspi.c b/src/security/tpm/tspi/tspi.c
index 144e3c31a0..6ef01383ce 100644
--- a/src/security/tpm/tspi/tspi.c
+++ b/src/security/tpm/tspi/tspi.c
@@ -7,7 +7,6 @@
 #include <security/tpm/tss.h>
 #include <assert.h>
 #include <security/vboot/misc.h>
-#include <string.h>
 #include <vb2_api.h>
 #include <vb2_sha.h>
 
diff --git a/src/security/vboot/secdata_tpm.c b/src/security/vboot/secdata_tpm.c
index 6a4dc712e2..d350b38262 100644
--- a/src/security/vboot/secdata_tpm.c
+++ b/src/security/vboot/secdata_tpm.c
@@ -7,7 +7,6 @@
 
 #include <security/vboot/antirollback.h>
 #include <security/vboot/tpm_common.h>
-#include <string.h>
 #include <security/tpm/tspi.h>
 #include <security/tpm/tss.h>
 #include <security/tpm/tss/tcg-1.2/tss_structures.h>
diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c
index fe52de1d95..b29cf7dd9e 100644
--- a/src/soc/intel/cannonlake/bootblock/report_platform.c
+++ b/src/soc/intel/cannonlake/bootblock/report_platform.c
@@ -11,7 +11,6 @@
 #include <soc/bootblock.h>
 #include <soc/pch.h>
 #include <soc/pci_devs.h>
-#include <string.h>
 
 #define BIOS_SIGN_ID	0x8B
 
diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c
index 9e154f453b..b985a94628 100644
--- a/src/soc/intel/common/block/cse/cse_lite.c
+++ b/src/soc/intel/common/block/cse/cse_lite.c
@@ -4,7 +4,6 @@
 #include <soc/intel/common/reset.h>
 #include <intelblocks/cse.h>
 #include <security/vboot/vboot_common.h>
-#include <string.h>
 
 /* Converts bp index to boot partition string */
 #define GET_BP_STR(bp_index) (bp_index ? "RW" : "RO")
diff --git a/src/soc/intel/common/block/cse/disable_heci.c b/src/soc/intel/common/block/cse/disable_heci.c
index e27783a6a7..664a2f7b30 100644
--- a/src/soc/intel/common/block/cse/disable_heci.c
+++ b/src/soc/intel/common/block/cse/disable_heci.c
@@ -10,7 +10,6 @@
 #include <intelblocks/pcr.h>
 #include <soc/pci_devs.h>
 #include <soc/pcr_ids.h>
-#include <string.h>
 
 #define CSME0_FBE	0xf
 #define CSME0_BAR	0x0
diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c
index a1a88180f2..8f337c1c1d 100644
--- a/src/soc/intel/common/block/smbus/smbuslib.c
+++ b/src/soc/intel/common/block/smbus/smbuslib.c
@@ -4,7 +4,6 @@
 #include <spd_bin.h>
 #include <device/smbus_def.h>
 #include <device/smbus_host.h>
-#include <string.h>
 #include "smbuslib.h"
 
 static void update_spd_len(struct spd_block *blk)
diff --git a/src/soc/qualcomm/sc7180/qupv3_i2c.c b/src/soc/qualcomm/sc7180/qupv3_i2c.c
index 7dea694060..b80c3dfcbb 100644
--- a/src/soc/qualcomm/sc7180/qupv3_i2c.c
+++ b/src/soc/qualcomm/sc7180/qupv3_i2c.c
@@ -10,7 +10,6 @@
 #include <soc/qupv3_config.h>
 #include <soc/qupv3_i2c.h>
 #include <stdint.h>
-#include <string.h>
 
 static void i2c_clk_configure(unsigned int bus, enum i2c_speed speed)
 {
-- 
cgit v1.2.3