From be11d9369b364253a29c8c4a7bc9a6288ff7df65 Mon Sep 17 00:00:00 2001 From: Seunghwan Kim Date: Wed, 14 Nov 2018 11:30:09 +0900 Subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only GPP_D0 is NC in 1st SKU board design, so we should control GPP_D0 for only 2nd SKU. BUG=none BRANCH=poppy TEST=emerge-nautilus coreboot Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Signed-off-by: Seunghwan Kim Reviewed-on: https://review.coreboot.org/29631 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/mainboard/google/poppy/variants/nautilus/Makefile.inc | 1 + src/mainboard/google/poppy/variants/nautilus/smihandler.c | 15 +++++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc index 130c940aa2..c71520601a 100644 --- a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc @@ -15,3 +15,4 @@ ramstage-y += mainboard.c ramstage-y += sku.c smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c +smm-$(CONFIG_HAVE_SMI_HANDLER) += sku.c diff --git a/src/mainboard/google/poppy/variants/nautilus/smihandler.c b/src/mainboard/google/poppy/variants/nautilus/smihandler.c index e355b01453..f23798eac3 100644 --- a/src/mainboard/google/poppy/variants/nautilus/smihandler.c +++ b/src/mainboard/google/poppy/variants/nautilus/smihandler.c @@ -16,13 +16,24 @@ #include #include #include +#include #define LTE3_PWROFF_L GPP_D0 void variant_smi_sleep(u8 slp_typ) { + uint32_t sku_id; + if (slp_typ == ACPI_S5) { - /* Turn off LTE module */ - gpio_set(LTE3_PWROFF_L, 0); + sku_id = variant_board_sku(); + + switch (sku_id) { + case SKU_1_NAUTILUS_LTE: + /* Turn off LTE module */ + gpio_set(LTE3_PWROFF_L, 0); + break; + default: + break; + } } } -- cgit v1.2.3