From cd96e829f1212e3736a23e81ae48bf0109da64cd Mon Sep 17 00:00:00 2001 From: Alexandru Gagniuc Date: Sat, 5 Apr 2014 10:21:57 -0500 Subject: hudson boards: Don't require ide.asl file on boards without IDE Not all boards which use the AMD Hudson southbridge have IDE. However, the southbridge's asl included an 'ide.asl' file which had to be present in $(mainboard_dir)/acpi. Address this issue by removing the inclusion of 'ide.asl' from the southbridge 'fch.asl' and remove 'ide.asl' from Hudson boards, none of which have IDE. If future hudosn board will come with IDE, the device can be declared in the PCIO scope of dsdt.asl, right below the inclusion of 'fch.asl'. Change-Id: Ie2efb7ebf8f5b527e26d7aaaeafbd3053a9a6b28 Signed-off-by: Alexandru Gagniuc Reviewed-on: http://review.coreboot.org/5459 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan Reviewed-by: Patrick Georgi --- src/mainboard/amd/parmer/acpi/ide.asl | 20 -------------------- src/mainboard/amd/thatcher/acpi/ide.asl | 20 -------------------- src/mainboard/asus/f2a85-m/acpi/ide.asl | 20 -------------------- src/mainboard/hp/pavilion_m6_1035dx/acpi/ide.asl | 20 -------------------- src/southbridge/amd/agesa/hudson/acpi/fch.asl | 5 ----- 5 files changed, 85 deletions(-) delete mode 100644 src/mainboard/amd/parmer/acpi/ide.asl delete mode 100644 src/mainboard/amd/thatcher/acpi/ide.asl delete mode 100644 src/mainboard/asus/f2a85-m/acpi/ide.asl delete mode 100644 src/mainboard/hp/pavilion_m6_1035dx/acpi/ide.asl diff --git a/src/mainboard/amd/parmer/acpi/ide.asl b/src/mainboard/amd/parmer/acpi/ide.asl deleted file mode 100644 index be4d9bb1d3..0000000000 --- a/src/mainboard/amd/parmer/acpi/ide.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -/* No IDE functionality */ diff --git a/src/mainboard/amd/thatcher/acpi/ide.asl b/src/mainboard/amd/thatcher/acpi/ide.asl deleted file mode 100644 index be4d9bb1d3..0000000000 --- a/src/mainboard/amd/thatcher/acpi/ide.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -/* No IDE functionality */ diff --git a/src/mainboard/asus/f2a85-m/acpi/ide.asl b/src/mainboard/asus/f2a85-m/acpi/ide.asl deleted file mode 100644 index be4d9bb1d3..0000000000 --- a/src/mainboard/asus/f2a85-m/acpi/ide.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -/* No IDE functionality */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ide.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/ide.asl deleted file mode 100644 index be4d9bb1d3..0000000000 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/ide.asl +++ /dev/null @@ -1,20 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2013 Sage Electronic Engineering, LLC - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -/* No IDE functionality */ diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl index 06b4fe7fd1..f56b69c291 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl @@ -67,11 +67,6 @@ Device(SDCN) { } /* end SDCN */ #if !CONFIG_SOUTHBRIDGE_AMD_AGESA_YANGTZE -/* 0:14.1 - Primary (and only) IDE channel */ -Device(IDEC) { - Name(_ADR, 0x00140001) - #include "acpi/ide.asl" -} /* end IDEC */ /* 0:14.4 - PCI slot 1, 2, 3 */ Device(PIBR) { -- cgit v1.2.3