From db52f23fbddfcfb9791389e8b8b8cfa085252ffa Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Fri, 14 Oct 2016 10:44:23 -0500 Subject: soc/intel/apollolake: clear PMC registers The clearing of the PMC registers was not being called resulting in state persisting across reboots. This state is queried and events are added to the eventlog like 'RTC reset' events. However, the RTC reset event is a one time thing so it should only be logged once. Without the clearing of the state the event was logged on every boot. BUG=chrome-os-partner:58496 Change-Id: I60aa7102977c2b1775ab8c54d1c147737d2af5e2 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/17027 Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) Reviewed-by: Andrey Petrov Reviewed-by: Paul Menzel --- src/soc/intel/apollolake/pmc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/soc/intel/apollolake/pmc.c b/src/soc/intel/apollolake/pmc.c index 4544e0d60d..ef39630aee 100644 --- a/src/soc/intel/apollolake/pmc.c +++ b/src/soc/intel/apollolake/pmc.c @@ -152,6 +152,9 @@ static void pmc_init(struct device *dev) /* Log power state */ pch_log_state(); + + /* Now that things have been logged clear out the PMC state. */ + clear_pmc_status(); } static const struct device_operations device_ops = { -- cgit v1.2.3