From dc5d24c83702fb7367761eb31110548e51d8bb92 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Wed, 7 Mar 2018 13:06:53 -0800 Subject: coreboot_table: Print GPIO state correctly for lb_gpios Looks like there's a typo in the GPIO state table we print as part of assembling the coreboot tables. Of course, high GPIOs are represented as 1 and low GPIOs as 0. Fix this display bug. Change-Id: I59b4d49955c13f920576dd09f463e2d399ab64e0 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/25022 Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/lib/coreboot_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index aeaff28313..d03b771f48 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -186,10 +186,10 @@ static void lb_gpios(struct lb_header *header) printk(BIOS_INFO, " low | "); switch (g->value) { case 0: - printk(BIOS_INFO, " high\n"); + printk(BIOS_INFO, " low\n"); break; case 1: - printk(BIOS_INFO, " low\n"); + printk(BIOS_INFO, " high\n"); break; default: printk(BIOS_INFO, "undefined\n"); -- cgit v1.2.3