From 7bcd6ecea625cbe528633617c51e09f376368202 Mon Sep 17 00:00:00 2001 From: Alex Thiessen Date: Thu, 4 Jan 2018 15:16:23 +0000 Subject: util/gitconfig: Use `make` in git hooks As the code was moved from the Makefile.inc to a separate file in commit 9ab8ae6a (util/gitconfig: Make gitconfig a bash script),`$(MAKE)` was replaced by `remake`, introducing dependency on this tool which is basically a `make` with debugging capabilities. Many developers don't have `remake` installed, leading to pre-commit hooks being not executed properly. Apparently this was an unintentional change. Furthermore, special treatment of `make` tool via the `%MAKE%` substitution performed during hooks' deployment is still desired. Use case is calling `remake gitconfig` to set `remake` as the `make` tool in the hooks. To accomplish this, add a parameter that is passed from the Makefile.inc to gitconfig.sh. Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897 Signed-off-by: Alex Thiessen Reviewed-on: https://review.coreboot.org/23096 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Martin Roth --- Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Makefile.inc') diff --git a/Makefile.inc b/Makefile.inc index f91e8d4297..0593d31f1f 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -574,7 +574,7 @@ update: dongle.py -c /dev/term/1 $(obj)/coreboot.rom EOF gitconfig: - util/gitconfig/gitconfig.sh + util/gitconfig/gitconfig.sh "$(MAKE)" include util/crossgcc/Makefile.inc -- cgit v1.2.3