From a2fc1aee446f7cafa0e275c69fcb54adb5bf233d Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Mon, 22 Jan 2018 21:41:58 -0700 Subject: payloads/nvramcui/payload.sh: Fix shellcheck warnings In payloads/nvramcui/payload.sh line 5: DIR=`dirname $0` ^-- SC2006: Use $(..) instead of deprecated `..` ^-- SC2086: Double quote to prevent globbing and word \ splitting. In payloads/nvramcui/payload.sh line 6: lpgcc -o $DIR/nvramcui.elf $DIR/nvramcui.c 2>&1 >/dev/null || exit 1 ^-- SC2086: Double quote to prevent globbing and word \ splitting. ^-- SC2086: Double quote to prevent \ globbing and word splitting. ^-- SC2069: The order of \ of the 2>&1 and the \ redirect matters. The \ 2>&1 has to be last. Change-Id: Iceab2d0df49c642f54e6b911793aa1479f542644 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/23373 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- payloads/nvramcui/payload.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'payloads/nvramcui/payload.sh') diff --git a/payloads/nvramcui/payload.sh b/payloads/nvramcui/payload.sh index 57ed38b3a6..3d171e6949 100755 --- a/payloads/nvramcui/payload.sh +++ b/payloads/nvramcui/payload.sh @@ -2,6 +2,6 @@ # # This is a trivial payload compile & find script for abuild # -DIR=`dirname $0` -lpgcc -o $DIR/nvramcui.elf $DIR/nvramcui.c 2>&1 >/dev/null || exit 1 +DIR=$(dirname "$0") +lpgcc -o "$DIR/nvramcui.elf" "$DIR/nvramcui.c" >/dev/null 2>&1 || exit 1 echo "$DIR/nvramcui.elf" -- cgit v1.2.3