From 6520ec0650c4af616e1da92a5d90263e895f50ca Mon Sep 17 00:00:00 2001 From: Asami Doi Date: Sun, 17 Mar 2019 14:26:08 +0900 Subject: src/arch/mips: Fix checkpatch warnings and errors This patch will fix these checkpatch errors in src/arch/mips/. - src/arch/mips/ashldi3.c:22: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' - src/arch/mips/bootblock_simple.c:35: WARNING: braces {} are not necessary for any arm of this statement Change-Id: Ic859913b93dc8ed6ff64b551c8a6baf72d28c75a Signed-off-by: Asami Doi Reviewed-on: https://review.coreboot.org/c/coreboot/+/31938 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner --- src/arch/mips/ashldi3.c | 2 +- src/arch/mips/bootblock_simple.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/arch/mips') diff --git a/src/arch/mips/ashldi3.c b/src/arch/mips/ashldi3.c index 9ee40efa41..f68d78ed60 100644 --- a/src/arch/mips/ashldi3.c +++ b/src/arch/mips/ashldi3.c @@ -19,7 +19,7 @@ #errror "What endian are you!?" #endif -typedef unsigned word_type; +typedef unsigned int word_type; long long __ashldi3(long long u, word_type b); struct DWstruct { diff --git a/src/arch/mips/bootblock_simple.c b/src/arch/mips/bootblock_simple.c index 40987d8bcd..84029ebedb 100644 --- a/src/arch/mips/bootblock_simple.c +++ b/src/arch/mips/bootblock_simple.c @@ -32,10 +32,10 @@ void main(void) bootblock_mmu_init(); - if (init_extra_hardware()) { + if (init_extra_hardware()) printk(BIOS_ERR, "bootblock_simple: failed to init HW.\n"); - } else { + else run_romstage(); - } + halt(); } -- cgit v1.2.3