From 53b08c347f54970cf5f6ce35b8e1a1fe5f8a11f9 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Mon, 10 Dec 2018 14:11:35 +0530 Subject: cpuid: Add helper function for cpuid(1) functions This patch introduces 3 helper function for cpuid(1) : 1. cpu_get_cpuid() -> to get processor id (from cpuid.eax) 2. cpu_get_feature_flags_ecx -> to get processor feature flag (from cpuid.ecx) 3. cpu_get_feature_flags_edx -> to get processor feature flag (from cpuid.edx) Above 3 helper functions are targeted to replace majority of cpuid(1) references. Change-Id: Ib96a7c79dadb1feff0b8d58aa408b355fbb3bc50 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/30123 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/arch/x86/mpspec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/arch/x86/mpspec.c') diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index b44662d38b..28a9080e2e 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -161,14 +161,12 @@ void smp_write_processors(struct mp_config_table *mc) unsigned int apic_version; unsigned int cpu_features; unsigned int cpu_feature_flags; - struct cpuid_result result; struct device *cpu; boot_apic_id = lapicid(); apic_version = lapic_read(LAPIC_LVR) & 0xff; - result = cpuid(1); - cpu_features = result.eax; - cpu_feature_flags = result.edx; + cpu_features = cpu_get_cpuid(); + cpu_feature_flags = cpu_get_feature_flags_edx(); /* order the output of the cpus to fix a bug in kernel 2.6.11 */ for (order_id = 0; order_id < 256; order_id++) { for (cpu = all_devices; cpu; cpu = cpu->next) { -- cgit v1.2.3