From ef62994b946b88fb30b22ab112a7f855c2f6e157 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Thu, 3 Jan 2019 11:39:15 +0200 Subject: northbridge/amdfam10: Deal with PCI_ADDR() better MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PCI_ADDR() is tightly coupled with different setup_resource_map() variants so move the declaration away from global namespace. In the implementation of setup_resource_map() use the bottom 12 bits as the register mask like the other variants do already. Change-Id: Iadedfe993621a4458ce8f12c5e98c8cee537d2db Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/30784 Reviewed-by: Angel Pons Reviewed-by: Arthur Heymans Tested-by: build bot (Jenkins) --- src/arch/x86/include/arch/io.h | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/arch') diff --git a/src/arch/x86/include/arch/io.h b/src/arch/x86/include/arch/io.h index 9e2a877906..e4e3067a75 100644 --- a/src/arch/x86/include/arch/io.h +++ b/src/arch/x86/include/arch/io.h @@ -235,12 +235,6 @@ static inline int __ffs(u32 value) #ifdef __SIMPLE_DEVICE__ -#define PCI_ADDR(SEGBUS, DEV, FN, WHERE) ( \ - (((SEGBUS) & 0xFFF) << 20) | \ - (((DEV) & 0x1F) << 15) | \ - (((FN) & 0x07) << 12) | \ - ((WHERE) & 0xFFF)) - #define PCI_DEV(SEGBUS, DEV, FN) ( \ (((SEGBUS) & 0xFFF) << 20) | \ (((DEV) & 0x1F) << 15) | \ -- cgit v1.2.3