From 10bc806ab33e1ce98223913975f307092e621c56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Sat, 4 Jan 2020 11:58:50 +0200 Subject: console/post: Split parts to arch/ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both IO port and cmos are currently arch/x86 only features. Change-Id: I010af3f645c0be38dd856657874c36103aebbdc2 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/38187 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/console/post.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) (limited to 'src/console/post.c') diff --git a/src/console/post.c b/src/console/post.c index b9a7557f63..33d85e7675 100644 --- a/src/console/post.c +++ b/src/console/post.c @@ -14,11 +14,9 @@ #include #include -#if CONFIG(POST_IO) -#include -#endif /* Write POST information */ +void __weak arch_post_code(uint8_t value) { } /* Some mainboards have very nice features beyond just a simple display. * They can override this function. @@ -27,16 +25,13 @@ void __weak mainboard_post(uint8_t value) { } void post_code(uint8_t value) { -#if !CONFIG(NO_POST) -#if CONFIG(CONSOLE_POST) - printk(BIOS_EMERG, "POST: 0x%02x\n", value); -#endif -#if CONFIG(CMOS_POST) - cmos_post_code(value); -#endif -#if CONFIG(POST_IO) - outb(value, CONFIG_POST_IO_PORT); -#endif -#endif + if (!CONFIG(NO_POST)) { + /* Assume this to be the most reliable and simplest type + for displaying POST so keep it first. */ + arch_post_code(value); + + if (CONFIG(CONSOLE_POST)) + printk(BIOS_EMERG, "POST: 0x%02x\n", value); + } mainboard_post(value); } -- cgit v1.2.3