From 4fe9813adb44b369c84a097b4be3101eddf6b19d Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Sat, 25 Jan 2014 15:55:28 +0100 Subject: src/cpu: Fix spelling of MTTR to MTRR Change-Id: Ia4718ac31a5b2bd12f8cda5e107aa878d74d2a03 Signed-off-by: Paul Menzel Reviewed-on: http://review.coreboot.org/4805 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc --- src/cpu/intel/haswell/cache_as_ram.inc | 12 ++++++------ src/cpu/intel/haswell/haswell.h | 16 ++++++++-------- src/cpu/intel/haswell/romstage.c | 20 ++++++++++---------- 3 files changed, 24 insertions(+), 24 deletions(-) (limited to 'src/cpu/intel') diff --git a/src/cpu/intel/haswell/cache_as_ram.inc b/src/cpu/intel/haswell/cache_as_ram.inc index 2d1e86fc09..36d56545da 100644 --- a/src/cpu/intel/haswell/cache_as_ram.inc +++ b/src/cpu/intel/haswell/cache_as_ram.inc @@ -185,7 +185,7 @@ before_romstage: call romstage_main /* Save return value from romstage_main. It contains the stack to use * after cache-as-ram is torn down. It also contains the information - * for setting up MTTRs. */ + * for setting up MTRRs. */ movl %eax, %ebx post_code(0x2f) @@ -249,23 +249,23 @@ before_romstage: /* Setup stack as indicated by return value from ramstage_main(). */ movl %ebx, %esp - /* Get number of MTTRs. */ + /* Get number of MTRRs. */ popl %ebx movl $MTRRphysBase_MSR(0), %ecx 1: testl %ebx, %ebx jz 1f - /* Low 32 bits of MTTR base. */ + /* Low 32 bits of MTRR base. */ popl %eax - /* Upper 32 bits of MTTR base. */ + /* Upper 32 bits of MTRR base. */ popl %edx /* Write MTRR base. */ wrmsr inc %ecx - /* Low 32 bits of MTTR mask. */ + /* Low 32 bits of MTRR mask. */ popl %eax - /* Upper 32 bits of MTTR mask. */ + /* Upper 32 bits of MTRR mask. */ popl %edx /* Write MTRR mask. */ wrmsr diff --git a/src/cpu/intel/haswell/haswell.h b/src/cpu/intel/haswell/haswell.h index 9ed00af632..dcd5dc70ea 100644 --- a/src/cpu/intel/haswell/haswell.h +++ b/src/cpu/intel/haswell/haswell.h @@ -175,14 +175,14 @@ void romstage_common(const struct romstage_params *params); * torn down. The following values are pushed onto the stack to setup the * MTRRs: * +0: Number of MTRRs - * +4: MTTR base 0 31:0 - * +8: MTTR base 0 63:32 - * +12: MTTR mask 0 31:0 - * +16: MTTR mask 0 63:32 - * +20: MTTR base 1 31:0 - * +24: MTTR base 1 63:32 - * +28: MTTR mask 1 31:0 - * +32: MTTR mask 1 63:32 + * +4: MTRR base 0 31:0 + * +8: MTRR base 0 63:32 + * +12: MTRR mask 0 31:0 + * +16: MTRR mask 0 63:32 + * +20: MTRR base 1 31:0 + * +24: MTRR base 1 63:32 + * +28: MTRR mask 1 31:0 + * +32: MTRR mask 1 63:32 * ... */ void * asmlinkage romstage_main(unsigned long bist); diff --git a/src/cpu/intel/haswell/romstage.c b/src/cpu/intel/haswell/romstage.c index edb2e80cdd..40a396d501 100644 --- a/src/cpu/intel/haswell/romstage.c +++ b/src/cpu/intel/haswell/romstage.c @@ -108,18 +108,18 @@ static void *setup_romstage_stack_after_car(void) * of physical address bits. */ mtrr_mask_upper = (1 << ((cpuid_eax(0x80000008) & 0xff) - 32)) - 1; - /* The order for each MTTR is value then base with upper 32-bits of + /* The order for each MTRR is value then base with upper 32-bits of * each value coming before the lower 32-bits. The reasoning for * this ordering is to create a stack layout like the following: * +0: Number of MTRRs - * +4: MTTR base 0 31:0 - * +8: MTTR base 0 63:32 - * +12: MTTR mask 0 31:0 - * +16: MTTR mask 0 63:32 - * +20: MTTR base 1 31:0 - * +24: MTTR base 1 63:32 - * +28: MTTR mask 1 31:0 - * +32: MTTR mask 1 63:32 + * +4: MTRR base 0 31:0 + * +8: MTRR base 0 63:32 + * +12: MTRR mask 0 31:0 + * +16: MTRR mask 0 63:32 + * +20: MTRR base 1 31:0 + * +24: MTRR base 1 63:32 + * +28: MTRR mask 1 31:0 + * +32: MTRR mask 1 63:32 */ /* Cache the ROM as WP just below 4GiB. */ @@ -158,7 +158,7 @@ static void *setup_romstage_stack_after_car(void) slot = stack_push(slot, top_of_ram | MTRR_TYPE_WRBACK); num_mtrrs++; - /* Save the number of MTTRs to setup. Return the stack location + /* Save the number of MTRRs to setup. Return the stack location * pointing to the number of MTRRs. */ slot = stack_push(slot, num_mtrrs); -- cgit v1.2.3