From df2dbbc8174b580ea3b30bff2b2c13daefa0de88 Mon Sep 17 00:00:00 2001 From: Daniel Lim Wee Soong Date: Fri, 29 Mar 2019 19:21:35 +0800 Subject: cpu/ti/am335x: Fix checkpatch warnings Replace occurences of 'unsigned' with 'unsigned int' to fix WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Daniel Lim Wee Soong Change-Id: I94665e8fcb4719521d143774aa84f630b10ee68a Reviewed-on: https://review.coreboot.org/c/coreboot/+/32119 Tested-by: build bot (Jenkins) Reviewed-by: ron minnich --- src/cpu/ti/am335x/gpio.c | 13 +++++++------ src/cpu/ti/am335x/gpio.h | 8 ++++---- 2 files changed, 11 insertions(+), 10 deletions(-) (limited to 'src/cpu/ti') diff --git a/src/cpu/ti/am335x/gpio.c b/src/cpu/ti/am335x/gpio.c index e1c696709b..2685839b23 100644 --- a/src/cpu/ti/am335x/gpio.c +++ b/src/cpu/ti/am335x/gpio.c @@ -18,9 +18,10 @@ #include #include -static struct am335x_gpio_regs *gpio_regs_and_bit(unsigned gpio, uint32_t *bit) +static struct am335x_gpio_regs *gpio_regs_and_bit(unsigned int gpio, + uint32_t *bit) { - unsigned bank = gpio / AM335X_GPIO_BITS_PER_BANK; + unsigned int bank = gpio / AM335X_GPIO_BITS_PER_BANK; if (bank >= ARRAY_SIZE(am335x_gpio_banks)) { printk(BIOS_ERR, "Bad gpio index %d.\n", gpio); @@ -38,7 +39,7 @@ void am335x_disable_gpio_irqs(void) write32(&am335x_gpio_banks[i]->irqstatus_clr_0, 0xffffffff); } -int gpio_direction_input(unsigned gpio) +int gpio_direction_input(unsigned int gpio) { uint32_t bit; struct am335x_gpio_regs *regs = gpio_regs_and_bit(gpio, &bit); @@ -49,7 +50,7 @@ int gpio_direction_input(unsigned gpio) return 0; } -int gpio_direction_output(unsigned gpio, int value) +int gpio_direction_output(unsigned int gpio, int value) { uint32_t bit; struct am335x_gpio_regs *regs = gpio_regs_and_bit(gpio, &bit); @@ -64,7 +65,7 @@ int gpio_direction_output(unsigned gpio, int value) return 0; } -int gpio_get_value(unsigned gpio) +int gpio_get_value(unsigned int gpio) { uint32_t bit; struct am335x_gpio_regs *regs = gpio_regs_and_bit(gpio, &bit); @@ -74,7 +75,7 @@ int gpio_get_value(unsigned gpio) return (read32(®s->datain) & bit) ? 1 : 0; } -int gpio_set_value(unsigned gpio, int value) +int gpio_set_value(unsigned int gpio, int value) { uint32_t bit; struct am335x_gpio_regs *regs = gpio_regs_and_bit(gpio, &bit); diff --git a/src/cpu/ti/am335x/gpio.h b/src/cpu/ti/am335x/gpio.h index c04a00ce0f..616c0afd9e 100644 --- a/src/cpu/ti/am335x/gpio.h +++ b/src/cpu/ti/am335x/gpio.h @@ -62,9 +62,9 @@ static struct am335x_gpio_regs * const am335x_gpio_banks[] = { void am335x_disable_gpio_irqs(void); -int gpio_direction_input(unsigned gpio); -int gpio_direction_output(unsigned gpio, int value); -int gpio_get_value(unsigned gpio); -int gpio_set_value(unsigned gpio, int value); +int gpio_direction_input(unsigned int gpio); +int gpio_direction_output(unsigned int gpio, int value); +int gpio_get_value(unsigned int gpio); +int gpio_set_value(unsigned int gpio, int value); #endif /* __CPU_TI_AM335X_CLOCK_H__ */ -- cgit v1.2.3