From 601b27596ffdf526adf5b41c1f8366a5fdddc554 Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Wed, 20 Feb 2013 09:24:29 -0800 Subject: ARMV7: minor tweaks to inter-stage calling and payload handling. Payloads, by design, can return. There's lots of mechanism in the payload code to support it, and the chooser payload relies on it. Hence, we should not mark the function call in exit_stage as noreturn. Not all ARM have unified caches, and it's not always easy to tell what to do. So we are very paranoid. Before we call between stages, we should carefully flush the dcache to memory and invalidate the icache. This may be more than is necessary on all architectures but it doesn't really hurt for the most part. So compile cache management code into all stages, and call the flush dcache/invalidate icache from all stages. Change-Id: Ib9cc625c4dfd2d7d4b3c69a74686cc655a9d6484 Signed-off-by: Ronald G. Minnich Reviewed-on: http://review.coreboot.org/2462 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/cpu/armltd/cortex-a9/Makefile.inc | 1 + src/cpu/samsung/exynos5250/Makefile.inc | 2 ++ 2 files changed, 3 insertions(+) (limited to 'src/cpu') diff --git a/src/cpu/armltd/cortex-a9/Makefile.inc b/src/cpu/armltd/cortex-a9/Makefile.inc index d1e7edfdee..f1a3689691 100644 --- a/src/cpu/armltd/cortex-a9/Makefile.inc +++ b/src/cpu/armltd/cortex-a9/Makefile.inc @@ -1,2 +1,3 @@ ramstage-y += cache.c romstage-y += cache.c +bootblock-y += cache.c diff --git a/src/cpu/samsung/exynos5250/Makefile.inc b/src/cpu/samsung/exynos5250/Makefile.inc index c9a9341641..33fcedcc40 100644 --- a/src/cpu/samsung/exynos5250/Makefile.inc +++ b/src/cpu/samsung/exynos5250/Makefile.inc @@ -9,6 +9,7 @@ bootblock-$(CONFIG_EARLY_CONSOLE) += clock_init.c bootblock-$(CONFIG_EARLY_CONSOLE) += clock.c bootblock-$(CONFIG_EARLY_CONSOLE) += soc.c bootblock-$(CONFIG_EARLY_CONSOLE) += uart.c +bootblock-y += exynos_cache.c romstage-y += clock.c romstage-y += clock_init.c @@ -28,6 +29,7 @@ ramstage-y += power.c ramstage-y += soc.c ramstage-$(CONFIG_CONSOLE_SERIAL_UART) += uart.c ramstage-y += cpu.c +ramstage-y += exynos_cache.c #ramstage-$(CONFIG_SATA_AHCI) += sata.c -- cgit v1.2.3