From 6e2357676fb9ccf202ac3dbc66c83a040f061a4e Mon Sep 17 00:00:00 2001 From: Myles Watson Date: Tue, 29 Sep 2009 14:56:15 +0000 Subject: Remove some warnings. Signed-off-by: Myles Watson Acked-by: Stefan Reinauer git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4686 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/cpu/amd/car/copy_and_run.c | 2 +- src/cpu/amd/car/post_cache_as_ram.c | 2 +- src/cpu/amd/model_fxx/init_cpus.c | 3 ++- src/cpu/amd/model_fxx/processor_name.c | 6 ++++-- src/cpu/x86/lapic/lapic_cpu_init.c | 4 ++-- 5 files changed, 10 insertions(+), 7 deletions(-) (limited to 'src/cpu') diff --git a/src/cpu/amd/car/copy_and_run.c b/src/cpu/amd/car/copy_and_run.c index f495f6dbba..79cae6bc83 100644 --- a/src/cpu/amd/car/copy_and_run.c +++ b/src/cpu/amd/car/copy_and_run.c @@ -4,7 +4,7 @@ */ #if CONFIG_CBFS == 1 -void cbfs_and_run_core(char*, unsigned ebp); +void cbfs_and_run_core(const char*, unsigned ebp); static void copy_and_run(void) { diff --git a/src/cpu/amd/car/post_cache_as_ram.c b/src/cpu/amd/car/post_cache_as_ram.c index 9e988f02be..c42e8339cb 100644 --- a/src/cpu/amd/car/post_cache_as_ram.c +++ b/src/cpu/amd/car/post_cache_as_ram.c @@ -27,10 +27,10 @@ static void inline __attribute__((always_inline)) memcopy(void *dest, const voi static void vErrata343(void) { +#ifdef BU_CFG2_MSR msr_t msr; unsigned int uiMask = 0xFFFFFFF7; -#ifdef BU_CFG2_MSR msr = rdmsr(BU_CFG2_MSR); msr.hi &= uiMask; // set bit 35 to 0 wrmsr(BU_CFG2_MSR, msr); diff --git a/src/cpu/amd/model_fxx/init_cpus.c b/src/cpu/amd/model_fxx/init_cpus.c index 435167e94a..f3f2f582f5 100644 --- a/src/cpu/amd/model_fxx/init_cpus.c +++ b/src/cpu/amd/model_fxx/init_cpus.c @@ -347,7 +347,8 @@ static unsigned init_cpus(unsigned cpu_init_detectedx) lapic_write(LAPIC_MSG_REG, (apicid<<24) | 0x44); // bsp can not check it before stop_this_cpu set_init_ram_access(); #if CONFIG_MEM_TRAIN_SEQ == 1 - train_ram_on_node(id.nodeid, id.coreid, sysinfo, STOP_CAR_AND_CPU); + train_ram_on_node(id.nodeid, id.coreid, sysinfo, + (unsigned) STOP_CAR_AND_CPU); #endif STOP_CAR_AND_CPU(); diff --git a/src/cpu/amd/model_fxx/processor_name.c b/src/cpu/amd/model_fxx/processor_name.c index cab92f73e4..f5372cdf4a 100644 --- a/src/cpu/amd/model_fxx/processor_name.c +++ b/src/cpu/amd/model_fxx/processor_name.c @@ -143,7 +143,7 @@ static inline unsigned int cpuid_ecx(unsigned int op) return ecx; } -static inline void strcpy(char *dst, char *src) +static inline void strcpy(char *dst, const char *src) { while (*src) *dst++ = *src++; } @@ -151,7 +151,9 @@ static inline void strcpy(char *dst, char *src) int init_processor_name(void) { +#if CONFIG_K8_REV_F_SUPPORT == 0 u32 EightBitBrandId; +#endif u32 BrandId; u32 BrandTableIndex; u32 NN; @@ -159,7 +161,7 @@ int init_processor_name(void) msr_t progmsr; int i; - char *processor_name_string=NULL; + const char *processor_name_string=NULL; char program_string[48]; unsigned int *program_values = (unsigned int *)program_string; diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 6d912e62d4..7d071cd72d 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -37,10 +37,11 @@ char *lowmem_backup_ptr; int lowmem_backup_size; #endif +extern char _secondary_start[]; + static void copy_secondary_start_to_1m_below(void) { #if CONFIG_RAMBASE >= 0x100000 - extern char _secondary_start[]; extern char _secondary_start_end[]; unsigned long code_size; unsigned long start_eip; @@ -74,7 +75,6 @@ static int lapic_start_cpu(unsigned long apicid) int timeout; unsigned long send_status, accept_status, start_eip; int j, num_starts, maxlvt; - extern char _secondary_start[]; /* * Starting actual IPI sequence... -- cgit v1.2.3