From db9eaf4cb2a2fe65b0d08dc5b47426f7399d6757 Mon Sep 17 00:00:00 2001 From: David Hendricks Date: Fri, 5 Apr 2013 15:38:12 -0700 Subject: snow/exynos5250: move board-specific power stuff to mainboard dir This moves highly board-specific code out from the Exynos5250 power_init() into Snow's romstage.c. There's no reason the CPU- specific code should care about which PMIC we are using and which bus it is on. Change-Id: I52313177395519cddcab11225fc23d5e50c4c4e3 Signed-off-by: David Hendricks Reviewed-on: http://review.coreboot.org/3034 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Ronald G. Minnich --- src/cpu/samsung/exynos5250/power.c | 60 +------------------------------------- 1 file changed, 1 insertion(+), 59 deletions(-) (limited to 'src/cpu') diff --git a/src/cpu/samsung/exynos5250/power.c b/src/cpu/samsung/exynos5250/power.c index 953bf5c518..ffba8c5f37 100644 --- a/src/cpu/samsung/exynos5250/power.c +++ b/src/cpu/samsung/exynos5250/power.c @@ -30,10 +30,6 @@ #include #include #include -#include - -#include "device/i2c.h" -#include "cpu/samsung/exynos5-common/i2c.h" static void ps_hold_setup(void) { @@ -130,64 +126,10 @@ void power_exit_wakeup(void) ((resume_func)power->inform0)(); } -/** - * Initialize the pmic voltages to power up the system - * This also calls i2c_init so that we can program the pmic - * - * REG_ENABLE = 0, needed to set the buck/ldo enable bit ON - * - * @return Return 0 if ok, else -1 - */ int power_init(void) { - int error = 0; - - /* - * FIXME(dhendrix): We will re-factor the caller of power_init() - * to start from a board-specific romstage file and do the i2c - * early setup. There is no reason CPU power init code should - * mess with board-specific i2c parameters. - */ - /* Set the i2c register address base so i2c works before FDT */ - i2c_set_early_reg(0x12c60000); - ps_hold_setup(); - i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE); - - /* - * We're using CR1616 coin cell battery that is non-rechargeable - * battery. But, BBCHOSTEN bit of the BBAT Charger Register in - * MAX77686 is enabled by default for charging coin cell. - * - * Also, we cannot meet the coin cell reverse current spec. in UL - * standard if BBCHOSTEN bit is enabled. - * - * Disable Coin BATT Charging - */ - error = max77686_disable_backup_batt(); - - error |= max77686_volsetting(PMIC_BUCK2, CONFIG_VDD_ARM_MV, - REG_ENABLE, MAX77686_MV); - error |= max77686_volsetting(PMIC_BUCK3, CONFIG_VDD_INT_UV, - REG_ENABLE, MAX77686_UV); - error |= max77686_volsetting(PMIC_BUCK1, CONFIG_VDD_MIF_MV, - REG_ENABLE, MAX77686_MV); - error |= max77686_volsetting(PMIC_BUCK4, CONFIG_VDD_G3D_MV, - REG_ENABLE, MAX77686_MV); - error |= max77686_volsetting(PMIC_LDO2, CONFIG_VDD_LDO2_MV, - REG_ENABLE, MAX77686_MV); - error |= max77686_volsetting(PMIC_LDO3, CONFIG_VDD_LDO3_MV, - REG_ENABLE, MAX77686_MV); - error |= max77686_volsetting(PMIC_LDO5, CONFIG_VDD_LDO5_MV, - REG_ENABLE, MAX77686_MV); - error |= max77686_volsetting(PMIC_LDO10, CONFIG_VDD_LDO10_MV, - REG_ENABLE, MAX77686_MV); - if (error != 0) { - power_shutdown(); - printk(BIOS_ERR, "power init failed\n"); - } - - return error; + return 0; } void power_enable_xclkout(void) -- cgit v1.2.3