From c8050f4bfcb781dbaf565684b21a4e04b1dc769e Mon Sep 17 00:00:00 2001 From: Bill XIE Date: Mon, 25 Sep 2017 15:54:04 +0800 Subject: device/dram/ddr2.c: fix a hidden syntax error introduced earlier MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A regression is hidden in commit 7eb0157fca33865783c1cc3c8e5cb2e327e551d7 (device/dram/ddr2.c: Decoding byte[12] bit7 as self refresh flag ), which breaks the build procedure when CONFIG_DEBUG_RAM_SETUP is set. Maybe it had better implement "printram" and the like as inline functions instead of macros. Change-Id: If956435bd0c39b1f3e722c2cfc48d2d0f35abc9b Signed-off-by: Bill XIE Reviewed-on: https://review.coreboot.org/21673 Reviewed-by: Arthur Heymans Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Nico Huber --- src/device/dram/ddr2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/device/dram/ddr2.c') diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index d524238b22..e06e3423a8 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -547,7 +547,7 @@ int spd_decode_ddr2(struct dimm_attr_st *dimm, u8 spd[SPD_SIZE_MAX_DDR2]) ret = SPD_STATUS_INVALID_FIELD; dimm->flags.self_refresh = (spd[12] >> 7) & 1; printram("The assembly supports self refresh: %s\n", - dimm->flags.self_refresh ? "true", "false"); + dimm->flags.self_refresh ? "true" : "false"); /* Number of PLLs on DIMM */ if (dimm->rev >= 0x11) -- cgit v1.2.3