From 992066a427238f0d5eda379857388b2f45eea179 Mon Sep 17 00:00:00 2001 From: Tobias Diedrich Date: Mon, 10 Nov 2014 22:21:58 +0100 Subject: spd_cache debug: Log invalid CRC checksum "SPD has a invalid or zero-valued CRC" is not a very useful message, so show the actual and expected values. Change-Id: I31a1cdacc82240c699627769d490b94f5d378e86 Signed-off-by: Tobias Diedrich Reviewed-on: http://review.coreboot.org/7393 Reviewed-by: Edward O'Callaghan Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel --- src/device/dram/spd_cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/device/dram') diff --git a/src/device/dram/spd_cache.c b/src/device/dram/spd_cache.c index 0032f327dd..7ecd1dce0f 100644 --- a/src/device/dram/spd_cache.c +++ b/src/device/dram/spd_cache.c @@ -52,7 +52,8 @@ int read_spd_from_cbfs(u8 *buf, int idx) if (((buf[SPD_CRC_LO] == 0) && (buf[SPD_CRC_HI] == 0)) || (buf[SPD_CRC_LO] != (crc & 0xff)) || (buf[SPD_CRC_HI] != (crc >> 8))) { - printk(BIOS_WARNING, "SPD has a invalid or zero-valued CRC\n"); + printk(BIOS_WARNING, "SPD CRC %02x%02x is invalid, should be %04x\n", + buf[SPD_CRC_HI], buf[SPD_CRC_LO], crc); buf[SPD_CRC_LO] = crc & 0xff; buf[SPD_CRC_HI] = crc >> 8; u16 i; -- cgit v1.2.3