From b6e2afb1ffe7683118ba879ca19ef6343f641d17 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Tue, 21 Jan 2020 08:57:00 -0700 Subject: src/device/pci_rom.c: Show device IDs on oprom failure On a device/option-rom ID mismatch, the option rom's IDs would get shown twice instead of showing the actual device's IDs. This was very confusing because the error showed matching IDs. BUG=None TEST=Shows mismatched IDs when option rom doesn't match the hardware Change-Id: I5a06d6a7319aa653c8a5e32ec3c5afb651d83140 Signed-off-by: Martin Roth Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+/2013180 Reviewed-by: Raul E Rangel Reviewed-on: https://review.coreboot.org/c/coreboot/+/39586 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Angel Pons --- src/device/pci_rom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/device/pci_rom.c') diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 816255d5e1..27f2d8dca2 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -98,7 +98,7 @@ struct rom_header *pci_rom_probe(struct device *dev) || dev->device != rom_data->device) && (vendev == mapped_vendev)) { printk(BIOS_ERR, "ID mismatch: vendor ID %04x, " - "device ID %04x\n", rom_data->vendor, rom_data->device); + "device ID %04x\n", dev->vendor, dev->device); return NULL; } -- cgit v1.2.3