From 563e614bcde9627b764445dfe2fe7cfca7e99c96 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Tue, 26 May 2020 12:04:35 -0700 Subject: resource_allocator_v4: Fix size of I/O hole at 0x3b0 Addressing comment from CB:41443 that was received after the change landed. memranges_create_hole() takes size as the last parameter. So, the I/O hole created at 0x3b0 needs to set size as 0x3df - 0x3b0 + 1 as 0x3df is the upper limit of that hole. Change-Id: I08fca283436924427e12c6c69edced7e51db42a9 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/c/coreboot/+/41737 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Angel Pons Reviewed-by: Aaron Durbin --- src/device/resource_allocator_v4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/device/resource_allocator_v4.c') diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c index ece7150b32..b65fc8bf37 100644 --- a/src/device/resource_allocator_v4.c +++ b/src/device/resource_allocator_v4.c @@ -330,7 +330,7 @@ static void constrain_domain_resources(const struct device *domain, struct memra * Don't allow allocations in the VGA I/O range. PCI has special cases for * that. */ - memranges_create_hole(ranges, 0x3b0, 0x3df); + memranges_create_hole(ranges, 0x3b0, 0x3df - 0x3b0 + 1); /* * Resource allocator no longer supports the legacy behavior where I/O resource -- cgit v1.2.3