From 2e0053b84098512c5b3c98394998e66a8f83803b Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sat, 5 Dec 2020 19:06:55 +0100 Subject: azalia: Use `azalia_enter_reset` function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Also tidy up some adjacent comments. Change-Id: I2e881900a52e42ab3f43ffe96cfbdcc63ff02e23 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/48358 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph Reviewed-by: Nico Huber Reviewed-by: Michael Niewöhner --- src/device/azalia_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/device') diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index 5e9c6c9466..e1899f13c0 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -72,8 +72,7 @@ static int codec_detect(u8 *base) if (!count) goto no_codec; - /* Set Bit 0 to 0 to enter reset state (BAR + 0x8)[0] */ - if (azalia_set_bits(base + HDA_GCTL_REG, 1, 0) < 0) + if (azalia_enter_reset(base) < 0) goto no_codec; if (azalia_exit_reset(base) < 0) -- cgit v1.2.3