From 4663f45caa2352760ee08ec28b9c2d6e2e8823f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Thu, 7 Mar 2019 14:18:28 +0200 Subject: device/pci_ops: Have only default PCI bus ops available MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the current state of the tree we do not utilise the mechanism of having per-device overrides for PCI bus ops. This change effectively inlines all PCI config accessors for ramstage as well. Change-Id: I11c37cadfcbef8fb5657dec6d620e6bccab311a4 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/31753 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Aaron Durbin --- src/device/Makefile.inc | 1 - src/device/pci_ops_mmconf.c | 39 --------------------------------------- 2 files changed, 40 deletions(-) delete mode 100644 src/device/pci_ops_mmconf.c (limited to 'src/device') diff --git a/src/device/Makefile.inc b/src/device/Makefile.inc index c325a7e5bd..711a403353 100644 --- a/src/device/Makefile.inc +++ b/src/device/Makefile.inc @@ -33,7 +33,6 @@ ramstage-$(CONFIG_HYPERTRANSPORT_PLUGIN_SUPPORT) += hypertransport.c ramstage-$(CONFIG_PCIX_PLUGIN_SUPPORT) += pcix_device.c ramstage-$(CONFIG_PCIEXP_PLUGIN_SUPPORT) += pciexp_device.c ramstage-$(CONFIG_CARDBUS_PLUGIN_SUPPORT) += cardbus_device.c -ramstage-$(CONFIG_MMCONF_SUPPORT) += pci_ops_mmconf.c endif subdirs-y += oprom dram diff --git a/src/device/pci_ops_mmconf.c b/src/device/pci_ops_mmconf.c deleted file mode 100644 index 2fcb96174f..0000000000 --- a/src/device/pci_ops_mmconf.c +++ /dev/null @@ -1,39 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include -#include -#include -#include - -#if (CONFIG_MMCONF_BASE_ADDRESS == 0) -#error "CONFIG_MMCONF_BASE_ADDRESS needs to be non-zero!" -#endif - -/* - * Functions for accessing PCI configuration space with mmconf accesses - */ - -static const struct pci_bus_operations pci_ops_mmconf = { - .read8 = pci_mmio_read_config8, - .read16 = pci_mmio_read_config16, - .read32 = pci_mmio_read_config32, - .write8 = pci_mmio_write_config8, - .write16 = pci_mmio_write_config16, - .write32 = pci_mmio_write_config32, -}; - -const struct pci_bus_operations *pci_bus_default_ops(void) -{ - return &pci_ops_mmconf; -} -- cgit v1.2.3