From b8fba86b143b471a2126411177b0236f08358b8e Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Wed, 17 Jun 2020 21:06:53 +0200 Subject: Kconfig: Escape variable to accommodate new Kconfig versions Kconfig 4.17 started using the $(..) syntax for environment variable expansion while we want to keep expansion to the build system. Older Kconfig versions (like ours) simply drop the escapes, not changing the behavior. While we could let Kconfig expand some of the variables, that only splits the handling in two places, making debugging harder and potentially messing with reproducible builds (e.g. when paths end up in configs), so escape them all. Change-Id: Ibc4087fdd76089352bd8dd0edb1351ec79ea4faa Signed-off-by: Patrick Georgi Reviewed-on: https://review.coreboot.org/c/coreboot/+/42481 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh Reviewed-by: Paul Menzel Reviewed-by: Frans Hendriks Reviewed-by: Wim Vervoorn --- src/device/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/device') diff --git a/src/device/Kconfig b/src/device/Kconfig index 6bb326506f..d0d72f9a77 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -779,10 +779,10 @@ config INTEL_GMA_ADD_VBT config INTEL_GMA_VBT_FILE string "VBT binary path and filename" depends on INTEL_GMA_ADD_VBT - default "src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/data.vbt" \ + default "src/mainboard/\$(MAINBOARDDIR)/variants/\$(VARIANT_DIR)/data.vbt" \ if INTEL_GMA_HAVE_VBT && VARIANT_DIR != "" - default "src/mainboard/$(MAINBOARDDIR)/data.vbt" if INTEL_GMA_HAVE_VBT - default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/vbt.bin" + default "src/mainboard/\$(MAINBOARDDIR)/data.vbt" if INTEL_GMA_HAVE_VBT + default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/vbt.bin" help The path and filename of the VBT binary. -- cgit v1.2.3