From ce9d8640b1cf14419783d839afc0c53184c70bbf Mon Sep 17 00:00:00 2001 From: Myles Watson Date: Wed, 19 Aug 2009 19:12:39 +0000 Subject: Add an error message if there is a zero-sized fixed resource. Fix the existing example of one. Signed-off-by: Myles Watson Acked-by: Patrick Georgi git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4557 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/devices/device.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/devices/device.c') diff --git a/src/devices/device.c b/src/devices/device.c index c0852f2fd3..58c247f212 100644 --- a/src/devices/device.c +++ b/src/devices/device.c @@ -556,8 +556,12 @@ static void constrain_resources(struct device *dev, struct constraints* limits) /* Constrain limits based on the fixed resources of this device. */ for (i = 0; i < dev->resources; i++) { res = &dev->resource[i]; - if (!res->size) + if (!res->size) { + /* It makes no sense to have 0-sized, fixed resources.*/ + printk_err("skipping %s@%lx fixed resource, size=0!\n", + dev_path(dev), res->index); continue; + } if (!(res->flags & IORESOURCE_FIXED)) continue; -- cgit v1.2.3