From 755db95d1a36a4bd64519d7e05b00d62e848c458 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sun, 11 Nov 2018 01:42:17 +0100 Subject: (console,drivers/uart)/Kconfig: Fix dependencies The dependencies of CONSOLE_SERIAL and DRIVERS_UART were somehow backwards. Fix that. Now, CONSOLE_SERIAL depends on DRIVERS_UART, because it's using its interface. The individual UART drivers select DRIVERS_UART, because they implement the interface and depend on the common UART code. Some guards had to be fixed (using CONSOLE_SERIAL now instead of DRIVERS_UART). Some other guards that were only about compilation of units were removed. We want to build test as much as possible, right? Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/29572 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner --- src/drivers/uart/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/drivers/uart') diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig index 1130aeb126..1f23a195f3 100644 --- a/src/drivers/uart/Kconfig +++ b/src/drivers/uart/Kconfig @@ -1,7 +1,5 @@ config DRIVERS_UART bool - default y if CONSOLE_SERIAL - default n config DRIVERS_UART_8250IO # FIXME: Shouldn't have a prompt, should default to n, and @@ -11,6 +9,7 @@ config DRIVERS_UART_8250IO default n if DRIVERS_UART_8250MEM || HAVE_UART_SPECIAL default n if NO_UART_ON_SUPERIO default y + select DRIVERS_UART config DRIVERS_UART_8250IO_SKIP_INIT def_bool n @@ -37,6 +36,7 @@ config UART_OVERRIDE_REFCLK config DRIVERS_UART_8250MEM bool default n + select DRIVERS_UART config DRIVERS_UART_8250MEM_32 bool @@ -46,6 +46,7 @@ config DRIVERS_UART_8250MEM_32 config HAVE_UART_SPECIAL bool default n + select DRIVERS_UART config DRIVERS_UART_OXPCIE bool "Oxford OXPCIe952" -- cgit v1.2.3